add version command #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
michalgr
requested changes
Nov 18, 2023
|
|
||
| Version = Command( | ||
| name="Version", | ||
| id=2, |
There was a problem hiding this comment.
Suggested change
| id=2, | |
| id=1, |
There was a problem hiding this comment.
The id still needs to be fixed
|
|
||
| VirtualMachine = CommandSet( | ||
| name="VirtualMachine", | ||
| id=1, | ||
| commands=[ | ||
| AllClasses, | ||
| Version, |
There was a problem hiding this comment.
Could we keep this sorted by command's id ?
There was a problem hiding this comment.
I have changed the order, by IDs of commands in the command set.
wekesa360
force-pushed
the
version-command
branch
from
c555586 to
e3d0bc5
Compare
wekesa360
force-pushed
the
version-command
branch
from
e3d0bc5 to
1b22575
Compare
Daquiver1
pushed a commit
to Daquiver1/ExtendedAndroidTools
that referenced
this pull request
Nov 21, 2023
Daquiver1
pushed a commit
to Daquiver1/ExtendedAndroidTools
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the
virtualMachineCommand Set adding theVersioncommand to the python DSL