-
Notifications
You must be signed in to change notification settings - Fork 253
Compare and record new at the same time #144
base: master
Are you sure you want to change the base?
Conversation
…ne at the same time
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Can I have some tests for this? |
_snapshotController.mode = recordMode ? FBSnapshotModeRecord : FBSnapshotModeCompare; | ||
} | ||
|
||
- (FBSnapshotTestMode)mode{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line before {
@nscoding Previously there were no tests included for recordMode. Do you want me to add some ? Or just small tests for recordMode<->mode ? |
hmm I've been think about this for a while, I am not really sure how this property will be used. Can you provide some examples on how this will be integrated with your CI tooling? |
The main idea is to make the process of creating new ref screenshots easier. |
Added ability to perform both record new image and compare with old one at the same time.
When i am reported about some diff in snapshots by the build server, sometimes i know that there was a small change in color, font or image asset. In this case i only want to regenerate my ref images. But during regeneration i really want to know that no other minor changes was made between test run on a build server and generation. It would be good to generate diffs of old ref images with a potential new one.