This repository has been archived by the owner on Sep 26, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Subscriber balance zero out when validity expire (Client dependent) #42
Open
shivkumarsah
wants to merge
1
commit into
facebookarchive:master
Choose a base branch
from
piyushabad88:sprint2_pr_balance_zero_out
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ | |
from endagaweb.models import SystemEvent | ||
from endagaweb.models import TimeseriesStat | ||
from endagaweb.ic_providers.nexmo import NexmoProvider | ||
|
||
from ccm.common import crdt | ||
|
||
@app.task(bind=True) | ||
def usageevents_to_sftp(self): | ||
|
@@ -439,3 +439,20 @@ def req_bts_log(self, obj, retry_delay=60*10, max_retries=432): | |
raise | ||
finally: | ||
obj.save() | ||
|
||
|
||
@app.task(bind=True) | ||
def zero_out_subscribers_balance(self): | ||
"""Subscriber balance zero outs when validity expires. | ||
|
||
This runs this as a periodic task managed by celerybeat. | ||
""" | ||
today = django.utils.timezone.now() | ||
subscribers = Subscriber.objects.filter( | ||
valid_through__lte=today) | ||
if not subscribers: | ||
return # Do nothing | ||
credit_balance = crdt.PNCounter("default").serialize() | ||
print "Validity expired for Susbcribers %s setting balance to 0" % ( | ||
[subscriber.imsi for subscriber in subscribers],) | ||
subscribers.update(crdt_balance=credit_balance) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just update the value to zero? |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to deal with crdt's. You can use the getter/setter
Subscriber
propertybalance