Skip to content
This repository has been archived by the owner on Sep 26, 2018. It is now read-only.

Show subscriber balance validity - DO NOT MERGE #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shivkumarsah
Copy link
Contributor

Please review.
On subscriber info tab, it will show balance validity of subscriber.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@@ -286,6 +286,14 @@ def get(self, request, imsi=None):
'date')[0].date
except IndexError:
context['created'] = None
try:
# Get balance expire date for subscriber's first number.
number_details = Number.objects.filter(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets tie balance to Subscriber since Numbers can move from one Subscriber to the next

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit# 62e328d

@facebook-github-bot
Copy link

@shivkumarsah updated the pull request - view changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants