Improve metro waiting times in E2E #48281
Closed
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This change bump maestro to the latest version as it present better reporting. ## Changelog: [Internal] - Bump maestro to 1.39.5 Differential Revision: D67273486
Summary: While working on Maestro E2E I realized that we were waiting for Metro to start even when metro was not running. This moves the waiting only when metro is actually started. I also added another waiting point as it takes several seconds for the app to load the bundle from metro the first time. Subsequent attempts are faster as the metro cache is warm. ## Changelog: [Internal] - Improve metro waiting times in E2E Differential Revision: D67273648
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67273648 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Dec 16, 2024
Summary: While working on Maestro E2E I realized that we were waiting for Metro to start even when metro was not running. This moves the waiting only when metro is actually started. I also added another waiting point as it takes several seconds for the app to load the bundle from metro the first time. Subsequent attempts are faster as the metro cache is warm. ## Changelog: [Internal] - Improve metro waiting times in E2E Differential Revision: D67273648
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Dec 17, 2024
Summary: While working on Maestro E2E I realized that we were waiting for Metro to start even when metro was not running. This moves the waiting only when metro is actually started. I also added another waiting point as it takes several seconds for the app to load the bundle from metro the first time. Subsequent attempts are faster as the metro cache is warm. ## Changelog: [Internal] - Improve metro waiting times in E2E Reviewed By: fabriziocucci Differential Revision: D67273648
|
This pull request has been merged in 4c4c87b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While working on Maestro E2E I realized that we were waiting for Metro to start even when metro was not running.
This moves the waiting only when metro is actually started.
I also added another waiting point as it takes several seconds for the app to load the bundle from metro the first time. Subsequent attempts are faster as the metro cache is warm.
Changelog:
[Internal] - Improve metro waiting times in E2E
Differential Revision: D67273648