Share common ShadowNode functionality in BaseTextInputShadowNode for Android #48165
+9
−238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 7, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
88fab82 to
f8a17b4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 7, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
f8a17b4 to
4c0a959
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 7, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
4c0a959 to
be7b8b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
force-pushed
the
export-D66914447
branch
from
be7b8b7 to
6fdc784
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 8, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 9, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
6fdc784 to
09a3b45
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 9, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
09a3b45 to
f9eaf6d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 9, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
f9eaf6d to
f700c42
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 10, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
f700c42 to
b4c6f09
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 10, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
b4c6f09 to
7e440ce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
force-pushed
the
export-D66914447
branch
from
7e440ce to
d073f1d
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 10, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
d073f1d to
bf0f8b9
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 10, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 11, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
bf0f8b9 to
955085f
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 11, 2024
…Android (facebook#48165) Summary: [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
955085f to
69ccb79
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 12, 2024
…Android (facebook#48165) Summary: [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
69ccb79 to
6e93934
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 12, 2024
…Android (facebook#48165) Summary: [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
6e93934 to
c64f6d8
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 12, 2024
…Android (facebook#48165) Summary: [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
c64f6d8 to
3052a0f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
…Android (facebook#48165) Summary: [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
3052a0f to
53dfa61
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android
This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation
Differential Revision: D66914447