Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency issues post mvfst/fbthrift introduction #148

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

earies
Copy link
Contributor

@earies earies commented Aug 31, 2023

Title: Update submodules/fix dependency break for fbcode_builder/cmake after mvfst introduction

Description:

  • Post mvfst introduction as a mandatory dependency to fbthrift, build
    breaks by way of build_openr.sh fbcode_builder/cmake. This also involved
    upreving the pinned hashes for dependencies since there are multiple
    variables at play.
  • Brought submodule dependencies up to date and enforced mvfst as dependency
    to fbthrift. Updated Github workflow to account for mvfst

Test Plan:

  • Successful build by way of build/build_openr.sh

- Update github CI/CD workflow to account for mvfst
@earies
Copy link
Contributor Author

earies commented Sep 1, 2023

Looks like the CI/CD pipeline here is quite heavy resulting in:

/usr/bin/ranlib: libopenrlib.a: No space left on device

@cooperlees
Copy link
Contributor

Looks like the CI/CD pipeline here is quite heavy resulting in:

/usr/bin/ranlib: libopenrlib.a: No space left on device

Hey mate - Yeah, this is known. There was plan to get our own large disk worker built and use that, but never been high priority.

Let me see if I can click import to internal and see how interal CI goes.

  • I'm not directly involved anymore, but can't imagine the internal CI could be passing here ...

@facebook-github-bot
Copy link
Contributor

@cooperlees has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@cooperlees has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants