Fix dependency issues post mvfst/fbthrift introduction #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Update submodules/fix dependency break for fbcode_builder/cmake after mvfst introduction
Description:
mvfst
introduction as a mandatory dependency tofbthrift
, buildbreaks by way of
build_openr.sh
fbcode_builder/cmake. This also involvedupreving the pinned hashes for dependencies since there are multiple
variables at play.
mvfst
as dependencyto
fbthrift
. Updated Github workflow to account formvfst
Test Plan:
build/build_openr.sh