Skip to content

Commit

Permalink
Fix secure thrift client connection timeout using kServiceConnSSLTimeout
Browse files Browse the repository at this point in the history
Summary:
Recently we have identified a few instances of TCP connection timeout for KvStore instance.

{P968496899}

By checking the code, I see the SSL connection is using the timeout setup for plaintext(500ms) instead of the `kServiceConnSSLTimeout`(1000ms).

Fix this.

Reviewed By: shih-hao-tseng

Differential Revision: D52611361

fbshipit-source-id: b893487d9db0aca7b219605be90c2cce377bdc8b
  • Loading branch information
Xiang Xu authored and facebook-github-bot committed Jan 9, 2024
1 parent bfe093c commit 9f398dd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion openr/kvstore/KvStore-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -1135,7 +1135,7 @@ KvStoreDb<ClientType>::KvStorePeer::getOrCreateThriftClient(
context,
folly::IPAddress(*peerSpec.peerAddr()), /* v6LinkLocal */
*peerSpec.ctrlPort(), /* port to establish TCP connection */
Constants::kServiceConnTimeout, /* client connection timeout */
Constants::kServiceConnSSLTimeout, /* client connection timeout */
Constants::kServiceProcTimeout, /* request processing timeout */
folly::AsyncSocket::anyAddress(), /* bindAddress */
maybeIpTos, /* IP_TOS value for control plane */
Expand Down

0 comments on commit 9f398dd

Please sign in to comment.