Pass the pointer of owning object in GCPointer::set() part I #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Oct 22, 2024
…k#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
3a9fa2a to
10ecb83
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 8, 2024
…k#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
10ecb83 to
65d3797
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 14, 2024
…k#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
65d3797 to
30a6c7a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 21, 2024
…k#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
30a6c7a to
02dfb5c
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 22, 2024
…k#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
02dfb5c to
e18bee9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 23, 2024
…k#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
e18bee9 to
2d81068
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 28, 2024
…thod (facebook#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
2d81068 to
503a099
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 2, 2024
…thod (facebook#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
503a099 to
d97ca85
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 10, 2024
…thod (facebook#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
d97ca85 to
58acd20
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
58acd20 to
270b69b
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 10, 2024
…thod (facebook#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
270b69b to
921d9d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 21, 2024
…thod (facebook#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 22, 2024
…thod (facebook#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
921d9d6 to
3a1a154
Compare
Differential Revision: D66727534
Differential Revision: D61675022
…er (facebook#1504) Summary: Pull Request resolved: facebook#1504 Large segment needs to be backed by a large storage size. StorageProvider currently always allocate fixed size of storage determined by HERMESVM_LOG_HEAP_SEGMENT_SIZE. This diffs adds support of allocating larger storage with below changes: 1. `newStorage()` and `deleteStorage()` takes additional `sz` parameter. 2. For `MallocStorageProvider` and `VMAllocateStorageProvider`, simply change the previous fixed storage size to passed in `sz`. 3. For `ContiguousVAStorageProvider`, use a BitVector to manage allocations and deallocations. This can be improved later if we observe fragmentations. The support of enabling different sizes of heap segment will be added later. Differential Revision: D61676721
Differential Revision: D61807366
…ize in base calss Differential Revision: D65828323
Differential Revision: D61747510
…s to AlignedHeapSegmentBase Differential Revision: D64713261
Differential Revision: D65638502
Differential Revision: D62171114
…ers (facebook#1513) Summary: Pull Request resolved: facebook#1513 Differential Revision: D62169632
… start address Differential Revision: D67481895
Differential Revision: D65701671
Differential Revision: D67556001
…wning cell to ctor of GCHermesValueBase Differential Revision: D62196480
…thod (facebook#1502) Summary: Pull Request resolved: facebook#1502 Differential Revision: D62222257
|
This pull request was exported from Phabricator. Differential Revision: D62222257 |
lavenzg
force-pushed
the
export-D62222257-to-static_h
branch
from
3a1a154 to
a48ea29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D62222257