Render Error objects in CDT #1471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60598446 |
|
This pull request was exported from Phabricator. Differential Revision: D60598446 |
EdmondChuiHW
added a commit
to EdmondChuiHW/hermes
that referenced
this pull request
Aug 13, 2024
Summary: X-link: facebook/react-native#45990 Pull Request resolved: facebook#1471 Changelog: [General][Added]: support for rendering Error objects in Chrome DevTools console As discussed in [Linkifying and symbolicating JavaScript Error stacks in Fusebox](https://docs.google.com/document/d/1JI_PPzxFRwRNii6pcx-4Cb7g8UTrqnZHCxaoynntIrM/edit) by hoxyq, Error objects in CDT currently displays a big blob of string. In this diff, we send the correct CDT params. Differential Revision: D60598446
EdmondChuiHW
force-pushed
the
export-D60598446
branch
from
e9dce27 to
a413426
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60598446 |
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebook#45990 X-link: facebook/hermes#1471 Changelog: [General][Added]: support for rendering Error objects in Chrome DevTools console As discussed in [Linkifying and symbolicating JavaScript Error stacks in Fusebox](https://docs.google.com/document/d/1JI_PPzxFRwRNii6pcx-4Cb7g8UTrqnZHCxaoynntIrM/edit) by hoxyq, Error objects in CDT currently displays a big blob of string. In this diff, we send the correct CDT params. Differential Revision: D60598446
|
This pull request was exported from Phabricator. Differential Revision: D60598446 |
EdmondChuiHW
added a commit
to EdmondChuiHW/hermes
that referenced
this pull request
Aug 14, 2024
Summary: X-link: facebook/react-native#45990 Pull Request resolved: facebook#1471 Changelog: [General][Added]: support for rendering Error objects in Chrome DevTools console As discussed in [Linkifying and symbolicating JavaScript Error stacks in Fusebox](https://docs.google.com/document/d/1JI_PPzxFRwRNii6pcx-4Cb7g8UTrqnZHCxaoynntIrM/edit) by hoxyq, Error objects in CDT currently displays a big blob of string. In this diff, we send the correct CDT params. Differential Revision: D60598446
EdmondChuiHW
force-pushed
the
export-D60598446
branch
from
a413426 to
716c326
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60598446 |
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Aug 14, 2024
Summary: Pull Request resolved: facebook#45990 X-link: facebook/hermes#1471 Changelog: [General][Added]: support for rendering Error objects in Chrome DevTools console As discussed in [Linkifying and symbolicating JavaScript Error stacks in Fusebox](https://docs.google.com/document/d/1JI_PPzxFRwRNii6pcx-4Cb7g8UTrqnZHCxaoynntIrM/edit) by hoxyq, Error objects in CDT currently displays a big blob of string. In this diff, we send the correct CDT params. Differential Revision: D60598446
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Aug 15, 2024
Summary: Pull Request resolved: facebook#45990 X-link: facebook/hermes#1471 Changelog: [General][Added]: support for rendering Error objects in Chrome DevTools console As discussed in [Linkifying and symbolicating JavaScript Error stacks in Fusebox](https://docs.google.com/document/d/1JI_PPzxFRwRNii6pcx-4Cb7g8UTrqnZHCxaoynntIrM/edit) by hoxyq, Error objects in CDT currently displays a big blob of string. In this diff, we send the correct CDT params. Reviewed By: hoxyq Differential Revision: D60598446
|
This pull request was exported from Phabricator. Differential Revision: D60598446 |
Summary: X-link: facebook/react-native#45990 Pull Request resolved: facebook#1471 Changelog: [General][Added]: support for rendering Error objects in Chrome DevTools console As discussed in [Linkifying and symbolicating JavaScript Error stacks in Fusebox](https://docs.google.com/document/d/1JI_PPzxFRwRNii6pcx-4Cb7g8UTrqnZHCxaoynntIrM/edit) by hoxyq, Error objects in CDT currently displays a big blob of string. In this diff, we send the correct CDT params. Reviewed By: hoxyq Differential Revision: D60598446
EdmondChuiHW
force-pushed
the
export-D60598446
branch
from
716c326 to
30b6563
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60598446 |
|
This pull request has been merged in 6b45693. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 16, 2024
Summary: Pull Request resolved: #45990 X-link: facebook/hermes#1471 Changelog: [General][Added]: support for rendering Error objects in Chrome DevTools console As discussed in [Linkifying and symbolicating JavaScript Error stacks in Fusebox](https://docs.google.com/document/d/1JI_PPzxFRwRNii6pcx-4Cb7g8UTrqnZHCxaoynntIrM/edit) by hoxyq, Error objects in CDT currently displays a big blob of string. In this diff, we send the correct CDT params. Reviewed By: hoxyq Differential Revision: D60598446 fbshipit-source-id: 527c4e5858dfb879a32b40e5ad4df73a22e694e5
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
Summary: Original Author: [email protected] Original Git: 6b45693 Original Reviewed By: hoxyq Original Revision: D60598446 X-link: facebook/react-native#45990 Pull Request resolved: #1471 Changelog: [General][Added]: support for rendering Error objects in Chrome DevTools console As discussed in [Linkifying and symbolicating JavaScript Error stacks in Fusebox](https://docs.google.com/document/d/1JI_PPzxFRwRNii6pcx-4Cb7g8UTrqnZHCxaoynntIrM/edit) by hoxyq, Error objects in CDT currently displays a big blob of string. In this diff, we send the correct CDT params. Reviewed By: mattbfb Differential Revision: D61574237 fbshipit-source-id: 73829455a50eb2e98a717cf2506edec10c9d758c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General][Added]: support for rendering Error objects in Chrome DevTools console
As discussed in Linkifying and symbolicating JavaScript Error stacks in Fusebox by hoxyq, Error objects in CDT currently displays a big blob of string.
In this diff, we send the correct CDT params.
Differential Revision: D60598446