Introduce LocalTimeOffsetCache #1446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52153598 |
|
This pull request was exported from Phabricator. Differential Revision: D52153598 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Jun 24, 2024
Summary: Pull Request resolved: facebook#1446 LocalTimeOffsetCache supports caching time zone standard offset and DST offset for time conversion between UTC and local. The caching mechanism is mostly the same as V8 (when ICU is not enabled). Reviewed By: dannysu Differential Revision: D52153598
lavenzg
force-pushed
the
export-D52153598
branch
from
2e549e9 to
ed3f239
Compare
Summary: Pull Request resolved: facebook#1446 LocalTimeOffsetCache supports caching time zone standard offset and DST offset for time conversion between UTC and local. The caching mechanism is mostly the same as V8 (when ICU is not enabled). Reviewed By: dannysu Differential Revision: D52153598
lavenzg
force-pushed
the
export-D52153598
branch
from
ed3f239 to
ca7b181
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52153598 |
|
This pull request has been merged in 9e199e9. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
Summary: Original Author: [email protected] Original Git: 9e199e9 Original Reviewed By: dannysu Original Revision: D52153598 Pull Request resolved: #1446 LocalTimeOffsetCache supports caching time zone standard offset and DST offset for time conversion between UTC and local. The caching mechanism is mostly the same as V8 (when ICU is not enabled). Reviewed By: lavenzg Differential Revision: D61574231 fbshipit-source-id: 99be7f33b836badb3ad160b44c600706ab91db5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
LocalTimeOffsetCache supports caching time zone standard offset and
DST offset for time conversion between UTC and local. The caching
mechanism is mostly the same as V8 (when ICU is not enabled).
Reviewed By: dannysu
Differential Revision: D52153598