Move SerialExecutor to Support #1404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Move SerialExecutor, and convert `throw`s to `assert`s so it can be built without exceptions. Differential Revision: D57689126
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57689126 |
|
This pull request was exported from Phabricator. Differential Revision: D57689126 |
4 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D57689126 |
|
This pull request was exported from Phabricator. Differential Revision: D57689126 |
|
This pull request was exported from Phabricator. Differential Revision: D57689126 |
|
This pull request was exported from Phabricator. Differential Revision: D57689126 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
Summary: Pull Request resolved: #1404 - Move SerialExecutor - convert `throw`s to `assert`s so it can be built without exceptions - only adjust the stack for ASAN if in an ASAN build Reviewed By: neildhar Differential Revision: D57689126 fbshipit-source-id: 06114de4be9493391507c9dc2fe2d689ec52b8ba
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 16, 2024
Summary: Original Author: [email protected] Original Git: d208805 Original Reviewed By: neildhar Original Revision: D57689126 Pull Request resolved: #1404 - Move SerialExecutor - convert `throw`s to `assert`s so it can be built without exceptions - only adjust the stack for ASAN if in an ASAN build Reviewed By: neildhar Differential Revision: D58621440 fbshipit-source-id: 8781a88aab126ad13177a29316e31e917d11484b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Move SerialExecutor, and convert
throws toasserts so it can be built without exceptions.Differential Revision: D57689126