Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Xforce-jit should allow multiple occurrences.
Summary: The SH dev wiki has this command for testing the JIT: ``` LIT_HERMES_EXTRA_FLAGS=-Xforce-jit ninja check-hermes ``` However, that command current produces 28 errors. Fortunately, they're all trivial. They are all tests in the test/jit directory, which already have an explicit -Xforce-jit in their run lines. The addition of the LIT_HERMES_EXTRA_FLAGS causes: ``` hermes: for the -Xforce-jit option: may only occur zero or one times! ``` The fix is simple: declare this option to be ZeroOrMore, instead of Optional. Aakash asks about the behavior of ZeroOrMore if there are multiple occurrences. From: https://llvm.org/docs/CommandLine.html#controlling-the-number-of-occurrences-required-and-allowed > If an option is specified multiple times for an option of the cl::opt class, only the last value will be retained. Reviewed By: avp Differential Revision: D65950456 fbshipit-source-id: b0fe60d42239d1b742a076d72c78c85d61550adc
- Loading branch information