platform_manager: add DARWIN48V platform support #260
Conversation
|
@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@adamcalabrigo has updated the pull request. You must reimport the pull request before landing. |
|
@adamcalabrigo has updated the pull request. You must reimport the pull request before landing. |
|
@adamcalabrigo has updated the pull request. You must reimport the pull request before landing. |
|
@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Could ROOK_CPU_CPLD be put under /run/devmap/fpgas? Would the firmware reporting be accurate in that case? Am I overlooking any other issue? |
| "pluggedInSlotType": "FAN_SLOT", | ||
| "i2cDeviceConfigs": [], | ||
| "outgoingSlotConfigs": {}, | ||
| "pciDeviceConfigs": [] |
There was a problem hiding this comment.
Are there no devices on the FAN PmUnit/FRU ?
There was a problem hiding this comment.
Correct, no devices. The CPLD provides the telemetry, and that is on the switch.
| "pmUnitName": "SMB" | ||
| }, | ||
| "FAN_SLOT": { | ||
| "numOutgoingI2cBuses": 0, |
There was a problem hiding this comment.
Do the fans have any presence detection and/or IDPROM ?
There was a problem hiding this comment.
The fan presence detection is provided by the FAN CPLD - this is reflected in the FAN_SLOT@X definitions in the outgoingSlotConfigs of the SMB.
| "numOutgoingI2cBuses": 1, | ||
| "pmUnitName": "PSU" |
There was a problem hiding this comment.
Do the PSUs have any presence detection and/or IDPROM ?
There was a problem hiding this comment.
The presence detection for the PSU is provided by the SCD_FPGA - this is detailed in the PSU_SLOT@0 presenceDetection definition.
Yes, that would resolve the firmware reading issue. It is, however, a departure from the current sysfs endpoint provided by the udev rules, so it's worth reviewing if you have any FBOSS or external logic that depends on this path before we change it. |
|
@adamcalabrigo has updated the pull request. You must reimport the pull request before landing. |
|
@adamcalabrigo has updated the pull request. You must reimport the pull request before landing. |
|
@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@joancaneus merged this pull request in 89567aa. |
Description
Adds initial
platform_managersupport forDARWIN48Vplatform. Note that this depends on the changes in #257.Test Plan
FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4.
Verified on DARWIN48V hardware.
The
platform_managerservice loads correctly:Device drivers are loaded correctly:
Note that
platform_managerreports one error while reading the firmware version of one CPLD: this is because the CPLD symlink is mapped to/run/devmap/cplds/for compatibility with existing DARWIN udev rules: