Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HW test suites to be compile in the hourly build. #239

Closed

Conversation

GoravGargCelestica
Copy link
Contributor

@GoravGargCelestica GoravGargCelestica commented Sep 24, 2024

Description

"Build & Test Platform Services" hourly build doesn't include the following FBOSS HW test suites, PR is raised to include these also:

  1. data_corral_service_hw_test
  2. fan_service_hw_test
  3. sensor_service_hw_test

Motivation

Aim is to generate all the FBOSS binaries using a common build environment to avoid any issue arising due to the build environment difference.

Testing

Compiled the FBOSS binaries using the following command which is taken from the platform-services.yml
https://github.com/facebook/fboss/blob/main/.github/workflows/platform-services.yml#L23-L32 :

./fboss/oss/scripts/docker-build.py --scratch-path build-output --target github_actions_fboss_platform_services --no-docker-output --no-system-deps --env-var GITHUB_ACTIONS_BUILD

Compiled binaries are available in the scratch path folder build-output:

[ggarg@AZUHPS25 fboss]$ ls -lh build-output/build/fboss/*hw_test
-rwxr-xr-x. 1 root root 72M Sep 24 05:17 build-output/build/fboss/data_corral_service_hw_test
-rwxr-xr-x. 1 root root 85M Sep 24 05:16 build-output/build/fboss/fan_service_hw_test
-rwxr-xr-x. 1 root root 89M Sep 24 05:16 build-output/build/fboss/sensor_service_hw_test
[ggarg@AZUHPS25 fboss]$

@GoravGargCelestica GoravGargCelestica changed the title Added HW test suites binaries also to be compile in hourly build. Added HW test suites to be compile in the hourly build. Sep 24, 2024
@facebook-github-bot
Copy link
Contributor

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@mikechoifb mikechoifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GoravGargCelestica , Actually Jimmy in FBOSS team has landed another diff including this change. So this is now duplicate. Would you mind cancelling this PR?

@GoravGargCelestica
Copy link
Contributor Author

Hi @GoravGargCelestica , Actually Jimmy in FBOSS team has landed another diff including this change. So this is now duplicate. Would you mind cancelling this PR?

Cancelling the PR as per the feedback from @mikechoifb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants