Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

montblanc : added led_manager.json #220

Conversation

GoravGargCelestica
Copy link
Contributor

@GoravGargCelestica GoravGargCelestica commented Sep 5, 2024

Description

Added led_manager.json file to verify the data_corral_service and the data_corral_service_hw_test.

Motivation

Aim is to verify the data_corral_service and the data_corral_service_hw_test.

Testing

  1. jq command output is clean.

  2. Data Corral Service Logs : mp3_data_corral_service_logs.txt

  3. Data Corral Service HW Test Logs : mp3_data_corral_service_hw_test_logs.txt

@facebook-github-bot
Copy link
Contributor

Hi @GoravGargCelestica!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@GoravGargCelestica has updated the pull request. You must reimport the pull request before landing.

@GoravGargCelestica GoravGargCelestica force-pushed the add_montblanc_led_manager_json branch from 6ca4c35 to 3f2f1a8 Compare September 18, 2024 04:32
@facebook-github-bot
Copy link
Contributor

@GoravGargCelestica has updated the pull request. You must reimport the pull request before landing.

@GoravGargCelestica GoravGargCelestica force-pushed the add_montblanc_led_manager_json branch from 3f2f1a8 to 41549aa Compare September 23, 2024 03:35
@facebook-github-bot
Copy link
Contributor

@GoravGargCelestica has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mikechoifb merged this pull request in 91005f8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants