Skip to content

Commit

Permalink
Kill unused API checkFabricConnectivityStats
Browse files Browse the repository at this point in the history
Summary: As titled

Reviewed By: shri-khare

Differential Revision:
D61421445

Privacy Context Container: L1125642

fbshipit-source-id: d7df9cb579f0d07494c93ecc4d5796488b652acd
  • Loading branch information
Jasmeet Bagga authored and facebook-github-bot committed Aug 17, 2024
1 parent b62fd28 commit 05204e3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 21 deletions.
20 changes: 0 additions & 20 deletions fboss/agent/test/utils/FabricTestUtils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,26 +61,6 @@ void checkFabricConnectivity(TestEnsembleIf* ensemble, SwitchID switchId) {
});
}

void checkFabricConnectivityStats(TestEnsembleIf* ensemble, SwitchID switchId) {
WITH_RETRIES({
ensemble->updateStats();
auto reachability = ensemble->getFabricConnectivity(switchId);
int count = 0;
for (auto [_, endpoint] : reachability) {
if (!*endpoint.isAttached()) {
continue;
}
// all interfaces which have reachability info collected
count++;
}
// expected all of interfaces to jump on mismatched and missing
EXPECT_EVENTUALLY_EQ(
*(ensemble->getFabricReachabilityStats().mismatchCount()), count);
EXPECT_EVENTUALLY_EQ(
*(ensemble->getFabricReachabilityStats().missingCount()), count);
});
}

void populatePortExpectedNeighbors(
const std::vector<PortID>& ports,
cfg::SwitchConfig& cfg) {
Expand Down
1 change: 0 additions & 1 deletion fboss/agent/test/utils/FabricTestUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

namespace facebook::fboss::utility {
void checkFabricConnectivity(TestEnsembleIf* ensemble, SwitchID switchId);
void checkFabricConnectivityStats(TestEnsembleIf* ensemble, SwitchID switchId);
void populatePortExpectedNeighbors(
const std::vector<PortID>& ports,
cfg::SwitchConfig& cfg);
Expand Down

0 comments on commit 05204e3

Please sign in to comment.