Remove meaningless enable check

Reviewed By: tianqibt Differential Revision: D18967766 fbshipit-source-id: 967f4162667352454a2b72e2cec93cf77fa84d8c
facebook · Dec 12, 2019 · 2a25647 · 2a25647
1 parent c52527a
commit 2a25647
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/...re/src/main/java/com/facebook/appevents/restrictivedatafilter/RestrictiveDataManager.java b/...re/src/main/java/com/facebook/appevents/restrictivedatafilter/RestrictiveDataManager.java
@@ -55,11 +55,7 @@ public synchronized static void enable() {
         initialize();
     }
 
-    public static synchronized void initialize() {
-        if (!enabled) {
-            return;
-        }
-
+    private static synchronized void initialize() {
         try {
             FetchedAppSettings settings = FetchedAppSettingsManager.queryAppSettings(
                     FacebookSdk.getApplicationId(), false);
@@ -159,7 +155,7 @@ public static void processParameters(Map<String, String> parameters, String even
 
                 parameters.put("_restrictedParams", restrictedJSON.toString());
             } catch (JSONException e) {
-                Log.w(TAG, "processParameters failed", e);
+                /* swallow */
             }
         }
     }

diff --git a/...rc/test/java/com/facebook/appevents/restrictivedatafilter/RestrictiveDataManagerTest.java b/...rc/test/java/com/facebook/appevents/restrictivedatafilter/RestrictiveDataManagerTest.java
@@ -119,7 +119,7 @@ public void testInitialize() throws Exception {
         BDDMockito.given(FetchedAppSettingsManager.queryAppSettings(Matchers.anyString(),
                 Matchers.anyBoolean())).willReturn(fetchedAppSettings);
 
-        RestrictiveDataManager.initialize();
+        RestrictiveDataManager.enable();
 
         List<RestrictiveDataManager.RestrictiveParam> restrictiveParams =
                 Whitebox.getInternalState(RestrictiveDataManager.class, "restrictiveParams");