Rename isEqualToComponent: to shouldComponentUpdate: to align it with…

… React Summary: Align our Reuse components API with React to make it clearer. Reviewed By: fabiomassimo Differential Revision: D9920055 fbshipit-source-id: 91bcdb973c59aeb09bede968752255db71fd098e
facebook · Sep 19, 2018 · 281ae39 · 281ae39
1 parent e03a61f
commit 281ae39
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 17 deletions.
diff --git a/ComponentKit/Core/ComponentTree/Protocols/CKRenderComponentProtocol.h b/ComponentKit/Core/ComponentTree/Protocols/CKRenderComponentProtocol.h
@@ -25,13 +25,13 @@
 + (id)initialStateWithComponent:(id<CKRenderComponentProtocol>)component;
 
 /*
- Override this method in order to allow the infrastructure to reuse previous components.
+ Override this method in order to allow ComopnentKit to reuse the previous components.
 
  You can always assume that the `component` parameter is the same type as your component.
 
- The default value is `NO`
+ The default value is `YES`.
  */
-- (BOOL)isEqualToComponent:(id<CKRenderComponentProtocol>)component;
+- (BOOL)shouldComponentUpdate:(id<CKRenderComponentProtocol>)component;
 
 /*
  This method is being called when the infrasturcture reuses the previous generation of the component.

diff --git a/ComponentKit/Core/Render/CKRenderComponent.mm b/ComponentKit/Core/Render/CKRenderComponent.mm
@@ -94,9 +94,9 @@ + (id)initialState
   return [CKTreeNodeEmptyState emptyState];
 }
 
-- (BOOL)isEqualToComponent:(id<CKRenderComponentProtocol>)component
+- (BOOL)shouldComponentUpdate:(id<CKRenderComponentProtocol>)component
 {
-  return NO;
+  return YES;
 }
 
 - (void)didReuseComponent:(id<CKRenderComponentProtocol>)component {}

diff --git a/ComponentKit/Core/Render/CKRenderLayoutComponent.mm b/ComponentKit/Core/Render/CKRenderLayoutComponent.mm
@@ -42,9 +42,9 @@ + (id)initialState
   return [CKTreeNodeEmptyState emptyState];
 }
 
-- (BOOL)isEqualToComponent:(id<CKRenderComponentProtocol>)component
+- (BOOL)shouldComponentUpdate:(id<CKRenderComponentProtocol>)component
 {
-  return NO;
+  return YES;
 }
 
 - (void)didReuseComponent:(id<CKRenderComponentProtocol>)component {}

diff --git a/ComponentKit/Core/Render/CKRenderLayoutWithChildrenComponent.mm b/ComponentKit/Core/Render/CKRenderLayoutWithChildrenComponent.mm
@@ -44,9 +44,9 @@ + (id)initialState
   return [CKTreeNodeEmptyState emptyState];
 }
 
-- (BOOL)isEqualToComponent:(id<CKRenderComponentProtocol>)component
+- (BOOL)shouldComponentUpdate:(id<CKRenderComponentProtocol>)component
 {
-  return NO;
+  return YES;
 }
 
 - (void)didReuseComponent:(id<CKRenderComponentProtocol>)component {}

diff --git a/ComponentKit/Core/Render/CKRenderWithChildrenComponent.mm b/ComponentKit/Core/Render/CKRenderWithChildrenComponent.mm
@@ -55,9 +55,9 @@ + (id)initialState
   return [CKTreeNodeEmptyState emptyState];
 }
 
-- (BOOL)isEqualToComponent:(id<CKRenderComponentProtocol>)component
+- (BOOL)shouldComponentUpdate:(id<CKRenderComponentProtocol>)component
 {
-  return NO;
+  return YES;
 }
 
 - (void)didReuseComponent:(id<CKRenderComponentProtocol>)component {}

diff --git a/ComponentKit/Core/Render/CKRenderWithSizeSpecComponent.mm b/ComponentKit/Core/Render/CKRenderWithSizeSpecComponent.mm
@@ -156,9 +156,9 @@ + (id)initialState
   return [CKTreeNodeEmptyState emptyState];
 }
 
-- (BOOL)isEqualToComponent:(id<CKRenderComponentProtocol>)component
+- (BOOL)shouldComponentUpdate:(id<CKRenderComponentProtocol>)component
 {
-  return NO;
+  return YES;
 }
 
 - (void)didReuseComponent:(id<CKRenderComponentProtocol>)component {}

diff --git a/ComponentKit/Utilities/CKRenderHelpers.mm b/ComponentKit/Utilities/CKRenderHelpers.mm
@@ -55,7 +55,7 @@ static auto reusePreviousComponentIfComponentsAreEqual(id<CKRenderComponentProto
                                                          id<CKTreeNodeWithChildrenProtocol> previousParent) -> BOOL {
     auto const previousChild = (CKRenderTreeNodeWithChild *)[previousParent childForComponentKey:node.componentKey];
     auto const previousComponent = (id<CKRenderComponentProtocol>)previousChild.component;
-    if (previousComponent && [component isEqualToComponent:previousComponent]) {
+    if (previousComponent && ![component shouldComponentUpdate:previousComponent]) {
       CKRenderInternal::reusePreviousComponent(component, childComponent, node, previousChild);
       return YES;
     }

diff --git a/ComponentKitTests/CKRenderComponentTests.mm b/ComponentKitTests/CKRenderComponentTests.mm
@@ -248,7 +248,7 @@ - (void)test_fasterPropsUpdate_componentIsNotBeingReused_whenPropsAreNotEqual
 - (void)test_fasterPropsUpdate_componentIsBeingReusedWhenPropsAreEqual
 {
   // Use the same componentIdentifier for both components.
-  // isEqualToComponent: will return YES in this case and we can reuse the component.
+  // shouldComponentUpdate: will return NO in this case and we can reuse the component.
   NSUInteger componentIdentifier = 1;
   [self setUpForFasterPropsUpdates:[CKTestRenderComponent newWithIdentifier:componentIdentifier]];
 
@@ -471,9 +471,9 @@ + (id)initialState
   return nil;
 }
 
-- (BOOL)isEqualToComponent:(CKTestRenderComponent *)component
+- (BOOL)shouldComponentUpdate:(CKTestRenderComponent *)component
 {
-  return _identifier == component->_identifier;
+  return _identifier != component->_identifier;
 }
 
 - (void)didReuseComponent:(CKTestRenderComponent *)component