Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required copyright headers to files missing it #1625

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Dcallies
Copy link
Contributor

Summary

The internal linter is complaining again, so do a fixup. There were a couple of tricky cases

  1. jinja template files, which I chose to implement via {# Comment #}
  2. A section of vpdq declared in the public domain in [vpdq] Upgrade Python binding to modern build system #1508. I am not a lawyer, so I tried to pick a compromise solution, @ianwal seems to have left github so can't ask him his opinion.

Test Plan

Let's see if CI is happy, and then I'll just view the HMA UI to make sure it still loads

@Dcallies
Copy link
Contributor Author

Well @ianwal, seems like you can like comments, but your profile and all previous PRs are hidden!

@Dcallies Dcallies merged commit f92308f into facebook:main Sep 24, 2024
11 of 12 checks passed
@Dcallies Dcallies deleted the copyright_headers branch September 24, 2024 17:08
@ianwal
Copy link
Contributor

ianwal commented Sep 24, 2024

Well @ianwal, seems like you can like comments, but your profile and all previous PRs are hidden!

I think my account is suspended because I can't search any code either 🫤. No clue why.

I don't see any compatibility problems with the changes vpdq license and a note about the public domain, from what I researched before (I'm also not a lawyer).

Update:
They flagged my account for spam but I contacted them and was able to get it removed. They said it just happens sometimes 🫤.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants