Migrate to native Chef helper functions #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
This PR will swap-out usage of custom
nodehelper functions to their corresponding native Chef helper function (when available). By changing this, we could also remove a lot of dependence upon Facebook's helper functions and allow your repo of cookbooks to be slightly more "portable" from one organization to the next (without having to bring in dependent cookbooks to serve a single puprose; like making a function definition available).Which issue(s) this PR fixes:
Fixes #265
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., Design Proposals, usage docs, etc.: