Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fully discrete, unordered benchmark problem #3211

Closed
wants to merge 1 commit into from

Conversation

esantorella
Copy link
Contributor

Summary:
This PR:

  • Moves IdentityTestFunction from test stubs to new file benchmark/test_functions/synthetic.py.
  • Adds get_bandit_problem, which uses a discrete search space on values 0, 1, ...9, so it can produce ground-truth metric values 0, 1, ... 9. It uses the inference trace (based on model-recommended best point) for scoring.

Reviewed By: Balandat

Differential Revision: D67535995

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 23, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67535995

esantorella added a commit to esantorella/Ax that referenced this pull request Dec 23, 2024
Summary:

This PR:
* Moves `IdentityTestFunction` from test stubs to new file `benchmark/test_functions/synthetic.py`.
* Adds `get_bandit_problem`, which uses a discrete search space on values 0, 1, ...9, so it can produce ground-truth metric values 0, 1, ... 9. It uses the inference trace (based on model-recommended best point) for scoring.

Reviewed By: Balandat

Differential Revision: D67535995
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67535995

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (ef1af42) to head (b516076).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3211   +/-   ##
=======================================
  Coverage   95.86%   95.87%           
=======================================
  Files         510      513    +3     
  Lines       51586    51636   +50     
=======================================
+ Hits        49455    49505   +50     
  Misses       2131     2131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

esantorella added a commit to esantorella/Ax that referenced this pull request Dec 23, 2024
Summary:

This PR:
* Moves `IdentityTestFunction` from test stubs to new file `benchmark/test_functions/synthetic.py`.
* Adds `get_bandit_problem`, which uses a discrete search space on values 0, 1, ...9, so it can produce ground-truth metric values 0, 1, ... 9. It uses the inference trace (based on model-recommended best point) for scoring.

Reviewed By: Balandat

Differential Revision: D67535995
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67535995

Summary:

This PR:
* Moves `IdentityTestFunction` from test stubs to new file `benchmark/test_functions/synthetic.py`.
* Adds `get_bandit_problem`, which uses a discrete search space on values 0, 1, ...9, so it can produce ground-truth metric values 0, 1, ... 9. It uses the inference trace (based on model-recommended best point) for scoring.

Reviewed By: Balandat

Differential Revision: D67535995
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67535995

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c561e7a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants