Make Acquisition.optimize work with discrete optimizer regardless of whether num_restarts is in optimizer_options
#3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67419600 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3197 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 510 510
Lines 51499 51521 +22
=======================================
+ Hits 49368 49390 +22
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
Summary: **Context**: Currently, benchmark metric tests conflate whether the metadata consumed by `fetch_trial_data` has multiple time steps with whether the output data should be `MapData`, and don't explicitly address the separate cases of whether or not there is a `BackendSimulator` attached to the metadata. They are also not organized well. These issues will become more pressing when we start to allow `BenchmarkMetric` to consume data with multiple time steps and/or use a backend simulator **This diff**: * Organizes those unit tests better * Adds some more checks Reviewed By: Balandat Differential Revision: D67281379
…er time (facebook#3184) Summary: **Context**: There are situations where a metric is not a MapMetric, but its value changes depending on time. **This diff**: Introduces `BenchmarkTimeVaryingMetric`, which is not a MapMetric, can consume data with multiple time steps, is available while running, and requires a backend simulator. Reviewed By: Balandat Differential Revision: D67224949
Summary: This diff * Changes some Pandas indexing to avoid a "setting with copy" warning * Corrects the docstring of `BenchmarkTrialMetadata` * Renames `ModelLauncherProblem` to `ModelLauncherTestFunction`, since it is a test function and not a problem Reviewed By: Balandat Differential Revision: D67419032
…f whether `num_restarts` is in `optimizer_options` (facebook#3197) Summary: Context: In `Acquisition.optimize`, we remove `raw_samples` from `optimizer_options` when the discrete optimizer was used (D63035021), but we don't do the same for `num_restarts` even though it is also not supported by the discrete optimizer. This PR: * Removes `num_restarts` from `optimizer_options` when the discrete optimizer is ued * Takes out a TODO to ensure it is never passed in the first place-- not feasible since we won't know if the optimizer is discrete before hitting that point Reviewed By: saitcakmak Differential Revision: D67419600
esantorella
force-pushed
the
export-D67419600
branch
from
4d93ad5 to
de9b232
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67419600 |
|
This pull request has been merged in f83d9a6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
In
Acquisition.optimize, we removeraw_samplesfromoptimizer_optionswhen the discrete optimizer was used (D63035021), but we don't do the same fornum_restartseven though it is also not supported by the discrete optimizer.This PR:
num_restartsfromoptimizer_optionswhen the discrete optimizer is uedDifferential Revision: D67419600