Have gen call into gen_with_multiple_nodes instead of gen_multiple
#3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67260951 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3187 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 509 509
Lines 51465 51470 +5
=======================================
+ Hits 49321 49327 +6
+ Misses 2144 2143 -1 ☔ View full report in Codecov by Sentry. |
…le` (facebook#3187) Summary: We have 4 `gen`-s in the gs file right now, this makes everyone sad. We want to be happy for the holidays. This diff is bigger than I like diffs to be sorry about that. Reviewed By: lena-kashtelyan Differential Revision: D67260951
mgarrard
force-pushed
the
export-D67260951
branch
from
2a3d2a5 to
72aeb6d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67260951 |
|
This pull request has been merged in 96d60c7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have 4 merges in the gs file right now, this makes everyone sad. We want to be happy for the holidays.
This diff is bigger than I like diffs to be sorry about that.
Differential Revision: D67260951