Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change normalize input constructor to accomodate tl modelbridge #3185

Closed
wants to merge 1 commit into from
Closed

change normalize input constructor to accomodate tl modelbridge #3185

wants to merge 1 commit into from

Conversation

jelena-markovic
Copy link
Contributor

Summary: Removing dependency of normalize transform for TL config on the properties of the search space.

Reviewed By: saitcakmak

Differential Revision: D67228575

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67228575

jelena-markovic pushed a commit to jelena-markovic/Ax that referenced this pull request Dec 17, 2024
@facebook-github-bot
change normalize input constructor to accomodate tl modelbridge (face…
bdcabb6 
…book#3185)

Summary:

Removing dependency of normalize transform for TL config on the properties of the search space.

Reviewed By: saitcakmak

Differential Revision: D67228575
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67228575

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67228575

jelena-markovic pushed a commit to jelena-markovic/Ax that referenced this pull request Dec 19, 2024
@facebook-github-bot
change normalize input constructor to accomodate tl modelbridge (face…
7918f7b 
…book#3185)

Summary:

Removing dependency of normalize transform for TL config on the properties of the search space.

Reviewed By: saitcakmak

Differential Revision: D67228575
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67228575

jelena-markovic pushed a commit to jelena-markovic/Ax that referenced this pull request Dec 19, 2024
@facebook-github-bot
change normalize input constructor to accomodate tl modelbridge (face…
1e6d293 
…book#3185)

Summary:

Removing dependency of normalize transform for TL config on the properties of the search space.

Reviewed By: saitcakmak

Differential Revision: D67228575
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67228575

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (433b38f) to head (558b023).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3185   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         510      510           
  Lines       51572    51577    +5     
=======================================
+ Hits        49440    49446    +6     
+ Misses       2132     2131    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67228575

jelena-markovic pushed a commit to jelena-markovic/Ax that referenced this pull request Dec 20, 2024
@facebook-github-bot
change normalize input constructor to accomodate tl modelbridge (face…
d2cc693 
…book#3185)

Summary:

Removing dependency of normalize transform for TL config on the properties of the search space.

Reviewed By: saitcakmak

Differential Revision: D67228575
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67228575

jelena-markovic pushed a commit to jelena-markovic/Ax that referenced this pull request Dec 20, 2024
@facebook-github-bot
change normalize input constructor to accomodate tl modelbridge (face…
9cba47d 
…book#3185)

Summary:

Removing dependency of normalize transform for TL config on the properties of the search space.

Reviewed By: saitcakmak

Differential Revision: D67228575
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67228575

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67228575

@facebook-github-bot
change normalize input constructor to accomodate tl modelbridge (face…
558b023 
…book#3185)

Summary:

Removing dependency of normalize transform for TL config on the properties of the search space.

Reviewed By: saitcakmak

Differential Revision: D67228575
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67228575

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1e16d48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelena-markovic @facebook-github-bot @codecov-commenter