Introduce BenchmarkTimeVaryingMetric for non-map metrics that vary over time #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D67224949 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3184 +/- ##
==========================================
- Coverage 95.83% 95.83% -0.01%
==========================================
Files 505 505
Lines 50989 51003 +14
==========================================
+ Hits 48866 48877 +11
- Misses 2123 2126 +3 ☔ View full report in Codecov by Sentry. |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 17, 2024
…er time (facebook#3184) Summary: **Context**: There are situations where a metric is not a MapMetric, but its value changes depending on time. **This diff**: Introduces `BenchmarkTimeVaryingMetric`, which is not a MapMetric, can consume data with multiple time steps, is available while running, and requires a backend simulator. Differential Revision: D67224949
esantorella
force-pushed
the
export-D67224949
branch
from
0079197 to
2516fa0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67224949 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 18, 2024
…er time (facebook#3184) Summary: **Context**: There are situations where a metric is not a MapMetric, but its value changes depending on time. **This diff**: Introduces `BenchmarkTimeVaryingMetric`, which is not a MapMetric, can consume data with multiple time steps, is available while running, and requires a backend simulator. Reviewed By: Balandat Differential Revision: D67224949
esantorella
force-pushed
the
export-D67224949
branch
from
2516fa0 to
ac706f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67224949 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 18, 2024
…er time (facebook#3184) Summary: **Context**: There are situations where a metric is not a MapMetric, but its value changes depending on time. **This diff**: Introduces `BenchmarkTimeVaryingMetric`, which is not a MapMetric, can consume data with multiple time steps, is available while running, and requires a backend simulator. Reviewed By: Balandat Differential Revision: D67224949
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 18, 2024
…er time (facebook#3184) Summary: **Context**: There are situations where a metric is not a MapMetric, but its value changes depending on time. **This diff**: Introduces `BenchmarkTimeVaryingMetric`, which is not a MapMetric, can consume data with multiple time steps, is available while running, and requires a backend simulator. Reviewed By: Balandat Differential Revision: D67224949
Summary: **Context**: Currently, benchmark metric tests conflate whether the metadata consumed by `fetch_trial_data` has multiple time steps with whether the output data should be `MapData`, and don't explicitly address the separate cases of whether or not there is a `BackendSimulator` attached to the metadata. They are also not organized well. These issues will become more pressing when we start to allow `BenchmarkMetric` to consume data with multiple time steps and/or use a backend simulator **This diff**: * Organizes those unit tests better * Adds some more checks Reviewed By: Balandat Differential Revision: D67281379
…er time (facebook#3184) Summary: **Context**: There are situations where a metric is not a MapMetric, but its value changes depending on time. **This diff**: Introduces `BenchmarkTimeVaryingMetric`, which is not a MapMetric, can consume data with multiple time steps, is available while running, and requires a backend simulator. Reviewed By: Balandat Differential Revision: D67224949
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 19, 2024
…er time (facebook#3184) Summary: **Context**: There are situations where a metric is not a MapMetric, but its value changes depending on time. **This diff**: Introduces `BenchmarkTimeVaryingMetric`, which is not a MapMetric, can consume data with multiple time steps, is available while running, and requires a backend simulator. Reviewed By: Balandat Differential Revision: D67224949
esantorella
force-pushed
the
export-D67224949
branch
from
ac706f8 to
41d3491
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67224949 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 19, 2024
…er time (facebook#3184) Summary: **Context**: There are situations where a metric is not a MapMetric, but its value changes depending on time. **This diff**: Introduces `BenchmarkTimeVaryingMetric`, which is not a MapMetric, can consume data with multiple time steps, is available while running, and requires a backend simulator. Reviewed By: Balandat Differential Revision: D67224949
|
This pull request has been merged in 9f57bb2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: There are situations where a metric is not a MapMetric, but its value changes depending on time.
This diff:
Introduces
BenchmarkTimeVaryingMetric, which is not a MapMetric, can consume data with multiple time steps, is available while running, and requires a backend simulator.Differential Revision: D67224949