Move get_improvement_over_baseline to the BestPointMixin #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66472613 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3156 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 502 503 +1
Lines 50811 50824 +13
=======================================
+ Hits 48690 48703 +13
Misses 2121 2121 ☔ View full report in Codecov by Sentry. |
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Dec 9, 2024
Summary: Pull Request resolved: facebook#3156 Differential Revision: D66472613
paschai
force-pushed
the
export-D66472613
branch
from
e0b1f3d to
23b9c32
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66472613 |
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Dec 9, 2024
Summary: Pull Request resolved: facebook#3156 Differential Revision: D66472613
paschai
force-pushed
the
export-D66472613
branch
from
23b9c32 to
9ba35e2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66472613 |
paschai
force-pushed
the
export-D66472613
branch
from
9ba35e2 to
909f9fd
Compare
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Dec 10, 2024
Summary: Pull Request resolved: facebook#3156 Differential Revision: D66472613
|
This pull request was exported from Phabricator. Differential Revision: D66472613 |
paschai
force-pushed
the
export-D66472613
branch
from
909f9fd to
89da541
Compare
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Dec 10, 2024
Summary: Pull Request resolved: facebook#3156 Differential Revision: D66472613
|
This pull request was exported from Phabricator. Differential Revision: D66472613 |
paschai
force-pushed
the
export-D66472613
branch
from
89da541 to
6d96d0a
Compare
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Dec 11, 2024
Summary: As titled - in this change we: 1. Move get_improvement_over_baseline to the BestPointMixin, and required an experiment and generation strategy 1. remove the required parameter of `baseline_arm_name` and utilize `select_baseline_arm()` if not provided 2. Introduce `best_point_utils.py` file to store `select_baseline_arm()` 3. Modified `select_baseline_arm()` to take in a dictionary of arm_names to Arms instead of a experiment df Differential Revision: D66472613
|
This pull request was exported from Phabricator. Differential Revision: D66472613 |
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Dec 12, 2024
Summary: As titled - in this change we: 1. Move get_improvement_over_baseline to the BestPointMixin, and required an experiment and generation strategy 1. remove the required parameter of `baseline_arm_name` and utilize `select_baseline_arm()` if not provided 2. Introduce `best_point_utils.py` file to store `select_baseline_arm()` 3. Modified `select_baseline_arm()` to take in a dictionary of arm_names to Arms instead of a experiment df Differential Revision: D66472613
paschai
force-pushed
the
export-D66472613
branch
from
6d96d0a to
e1aad81
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66472613 |
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Dec 12, 2024
Summary: As titled - in this change we: 1. Move get_improvement_over_baseline to the BestPointMixin, and required an experiment and generation strategy 1. remove the required parameter of `baseline_arm_name` and utilize `select_baseline_arm()` if not provided 2. Introduce `best_point_utils.py` file to store `select_baseline_arm()` 3. Modified `select_baseline_arm()` to take in a dictionary of arm_names to Arms instead of a experiment df Differential Revision: D66472613
paschai
force-pushed
the
export-D66472613
branch
from
e1aad81 to
d6a52a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66472613 |
Summary: As titled - in this change we: 1. Move get_improvement_over_baseline to the BestPointMixin, and required an experiment and generation strategy 1. remove the required parameter of `baseline_arm_name` and utilize `select_baseline_arm()` if not provided 2. Introduce `best_point_utils.py` file to store `select_baseline_arm()` 3. Modified `select_baseline_arm()` to take in a dictionary of arm_names to Arms instead of a experiment df Reviewed By: lena-kashtelyan Differential Revision: D66472613
paschai
force-pushed
the
export-D66472613
branch
from
d6a52a8 to
666df78
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D66472613 |
|
This pull request has been merged in 7ea8402. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D66472613