move deprecation warnings to SurrogateSpec and pass surrogate_spec to Surrogate #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65321401 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Nov 6, 2024
… Surrogate (facebook#3025) Summary: See title. This avoids defining the same arguments in two places, per feedback from Sait. Moving deprecation warnings to SurrogateSpec means warnings are raised raised while specifying the model rather than when it is instantiated. Reviewed By: saitcakmak Differential Revision: D65321401
sdaulton
force-pushed
the
export-D65321401
branch
from
e4caa07 to
a0c1426
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65321401 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3025 +/- ##
==========================================
- Coverage 95.60% 95.60% -0.01%
==========================================
Files 483 483
Lines 49012 49112 +100
==========================================
+ Hits 46859 46954 +95
- Misses 2153 2158 +5 ☔ View full report in Codecov by Sentry. |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Nov 6, 2024
… Surrogate (facebook#3025) Summary: See title. This avoids defining the same arguments in two places, per feedback from Sait. Moving deprecation warnings to SurrogateSpec means warnings are raised raised while specifying the model rather than when it is instantiated. Reviewed By: saitcakmak Differential Revision: D65321401
sdaulton
force-pushed
the
export-D65321401
branch
from
a0c1426 to
b6fb511
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65321401 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Nov 6, 2024
… Surrogate (facebook#3025) Summary: See title. This avoids defining the same arguments in two places, per feedback from Sait. Moving deprecation warnings to SurrogateSpec means warnings are raised raised while specifying the model rather than when it is instantiated. Reviewed By: saitcakmak Differential Revision: D65321401
sdaulton
force-pushed
the
export-D65321401
branch
from
b6fb511 to
0d9ca17
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65321401 |
Summary: Enables using different models for different metrics. * Adds ModelConfig dataclass to specify a single botorch model configuration * Adds a list of ModelConfigs to SurrogateSpec * Adds a dictionary mapping metric names to list of ModelConfigs to enable per-metric model specification * Lists of model configs are used to enable per-metric model selection across multiple ModelConfigs in a subsequent diff. Reviewed By: saitcakmak Differential Revision: D64793595
… Surrogate (facebook#3025) Summary: See title. This avoids defining the same arguments in two places, per feedback from Sait. Moving deprecation warnings to SurrogateSpec means warnings are raised raised while specifying the model rather than when it is instantiated. Reviewed By: saitcakmak Differential Revision: D65321401
sdaulton
force-pushed
the
export-D65321401
branch
from
0d9ca17 to
c8fb1ba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65321401 |
|
This pull request has been merged in 647bdc5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: See title. This avoids defining the same arguments in two places, per feedback from Sait. Moving deprecation warnings to SurrogateSpec means warnings are raised raised while specifying the model rather than when it is instantiated.
Reviewed By: saitcakmak
Differential Revision: D65321401