Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to mnist_train_nas.py in early stopping tutorial #2126

Closed
wants to merge 1 commit into from

Conversation

danielcohenlive
Copy link

@danielcohenlive danielcohenlive commented Jan 9, 2024

image

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 9, 2024
@facebook-github-bot
Copy link
Contributor

@danielcohenlive has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@saitcakmak saitcakmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Let's make sure https://github.com/facebook/Ax/actions/runs/7468012344/job/20322635991?pr=2126 succeeds before landing.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5230a53) 94.79% compared to head (7966b0e) 94.79%.
Report is 2 commits behind head on main.

❗ Current head 7966b0e differs from pull request most recent head ed96935. Consider uploading reports for the commit ed96935 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2126   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files         460      460           
  Lines       45400    45401    +1     
=======================================
+ Hits        43039    43040    +1     
  Misses       2361     2361           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@danielcohenlive merged this pull request in a499bd9.

@saitcakmak saitcakmak deleted the fix-early-stopping-tutorial branch April 4, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants