Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tune_cnn.ipynb; fix broken link #1980

Closed
wants to merge 1 commit into from

Conversation

esantorella
Copy link
Contributor

The material in tune_cnn.ipynb is redundant with the material in tune_cnn_service.ipynb. It is also creating a link because the tutorials.json markdown file points to the latter tutorial, while tutorials/index.js points to the former. This PR removes tune_cnn.ipynb and fixes the broken link by having both point to tune_cnn_service.ipynb.

I also removed an unused variable in index.js.

Test plan

I built tutorials tutorials locally and served the website with ./scripts/make_docs.sh and confirmed that the link works now.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 10, 2023
@facebook-github-bot
Copy link
Contributor

@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46418da) 94.46% compared to head (6b71e55) 94.46%.

❗ Current head 6b71e55 differs from pull request most recent head 74943e2. Consider uploading reports for the commit 74943e2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1980   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files         460      460           
  Lines       44032    44032           
=======================================
  Hits        41595    41595           
  Misses       2437     2437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@esantorella merged this pull request in 1186380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants