Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & temporarily disable raytune tutorial, print tutorial execution errors & memory usage #1974

Closed
wants to merge 14 commits into from

Conversation

saitcakmak
Copy link
Contributor

@saitcakmak saitcakmak commented Nov 10, 2023

The tutorials script has been updated to mimic the setup in the BoTorch script to print out the errors encountered while running the tutorials.

The raytune tutorial mysteriously fails even after fixing the deprecation errors, so we'll temporarily remove it from the CI. The early stopping tutorial fails trial execution both when run locally and with this diff, so that's also disabled temporarily.

The tutorial changes address the deprecation warning / error:

DeprecationWarning: `tune.report` is deprecated.
Use `ray.train.report` instead -- see the example below:

from ray import tune     ->     from ray import train
tune.report(metric=1)    ->     train.report({'metric': 1})

Also reduces # of trials from 30 to 10.

Test Plan:

Ran python scripts/make_tutorials.py -w $(pwd) -e -s locally and checked the outputs (including with added errors in the tutorials).

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b7712c) 94.46% compared to head (80da1f8) 94.46%.

❗ Current head 80da1f8 differs from pull request most recent head 865eb03. Consider uploading reports for the commit 865eb03 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1974   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files         460      460           
  Lines       44033    44033           
=======================================
  Hits        41596    41596           
  Misses       2437     2437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saitcakmak saitcakmak changed the title Reduce # of trials in raytune tutorial Fix deprecated functionality and reduce # of trials in raytune tutorial Nov 10, 2023
@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@saitcakmak saitcakmak changed the title Fix deprecated functionality and reduce # of trials in raytune tutorial Fix & temporarily disable raytune tutorial Nov 10, 2023
@saitcakmak saitcakmak changed the title Fix & temporarily disable raytune tutorial Fix & temporarily disable raytune tutorial, print tutorial execution errors & memory usage Nov 10, 2023
@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

scripts/make_tutorials.py Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@saitcakmak merged this pull request in 0d0ea07.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants