-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix & temporarily disable raytune tutorial, print tutorial execution errors & memory usage #1974
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 460 460
Lines 44033 44033
=======================================
Hits 41596 41596
Misses 2437 2437 ☔ View full report in Codecov by Sentry. |
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@saitcakmak merged this pull request in 0d0ea07. |
The tutorials script has been updated to mimic the setup in the BoTorch script to print out the errors encountered while running the tutorials.
The raytune tutorial mysteriously fails even after fixing the deprecation errors, so we'll temporarily remove it from the CI. The early stopping tutorial fails trial execution both when run locally and with this diff, so that's also disabled temporarily.
The tutorial changes address the deprecation warning / error:
Also reduces # of trials from 30 to 10.
Test Plan:
Ran
python scripts/make_tutorials.py -w $(pwd) -e -s
locally and checked the outputs (including with added errors in the tutorials).