Add transition_to argument to TransitionCriterion #1921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgarrard
force-pushed
the
export-D50295684
branch
from
5e2810e to
4d19a91
Compare
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1921 +/- ##
=======================================
Coverage 94.58% 94.59%
=======================================
Files 459 459
Lines 43411 43426 +15
=======================================
+ Hits 41061 41078 +17
+ Misses 2350 2348 -2
☔ View full report in Codecov by Sentry. |
mgarrard
force-pushed
the
export-D50295684
branch
from
4d19a91 to
402e63c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50295684 |
mgarrard
force-pushed
the
export-D50295684
branch
from
402e63c to
e2bd0dd
Compare
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Oct 23, 2023
Summary: It is important that the transition criteria can tell the GenerationStrategy which node to move to once the criteria is met. This diff adds the transition_to field to TransitionCriterion Things in the pipeline: (1) Update the transition criterion class to check on a per node basis, instead of per experiment (2) Use the transition criterion to determine if a node is complete (3) add is_complete to generationNode and then use that in generation Strategy for moving forward (4) [Mby] skip max trial criterion addition if numtrials == -1 (5) add transition criterion to the repr string + some of the other fields that havent made it yet (6) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed Reviewed By: lena-kashtelyan Differential Revision: D50295684
mgarrard
force-pushed
the
export-D50295684
branch
from
e2bd0dd to
c4517bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50295684 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50295684 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 24, 2023
Summary: It is important that the transition criteria can tell the GenerationStrategy which node to move to once the criteria is met. This diff adds the transition_to field to TransitionCriterion Things in the pipeline: (1) Update the transition criterion class to check on a per node basis, instead of per experiment (2) Use the transition criterion to determine if a node is complete (3) add is_complete to generationNode and then use that in generation Strategy for moving forward (4) [Mby] skip max trial criterion addition if numtrials == -1 (5) add transition criterion to the repr string + some of the other fields that havent made it yet (6) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed Reviewed By: lena-kashtelyan Differential Revision: D50295684
mgarrard
force-pushed
the
export-D50295684
branch
from
c4517bf to
c10044e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50295684 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Oct 24, 2023
Summary: It is important that the transition criteria can tell the GenerationStrategy which node to move to once the criteria is met. This diff adds the transition_to field to TransitionCriterion Things in the pipeline: (1) Update the transition criterion class to check on a per node basis, instead of per experiment (2) Use the transition criterion to determine if a node is complete (3) add is_complete to generationNode and then use that in generation Strategy for moving forward (4) [Mby] skip max trial criterion addition if numtrials == -1 (5) add transition criterion to the repr string + some of the other fields that havent made it yet (6) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed Reviewed By: lena-kashtelyan Differential Revision: D50295684
mgarrard
force-pushed
the
export-D50295684
branch
from
c10044e to
0b55e22
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50295684 |
Summary: It is important that the transition criteria can tell the GenerationStrategy which node to move to once the criteria is met. This diff adds the transition_to field to TransitionCriterion Things in the pipeline: (1) Update the transition criterion class to check on a per node basis, instead of per experiment (2) Use the transition criterion to determine if a node is complete (3) add is_complete to generationNode and then use that in generation Strategy for moving forward (4) [Mby] skip max trial criterion addition if numtrials == -1 (5) add transition criterion to the repr string + some of the other fields that havent made it yet (6) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed Reviewed By: lena-kashtelyan Differential Revision: D50295684
mgarrard
force-pushed
the
export-D50295684
branch
from
0b55e22 to
3eb4da3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50295684 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Oct 24, 2023
Summary: It is important that the transition criteria can tell the GenerationStrategy which node to move to once the criteria is met. This diff adds the transition_to field to TransitionCriterion Things in the pipeline: (1) Update the transition criterion class to check on a per node basis, instead of per experiment (2) Use the transition criterion to determine if a node is complete (3) add is_complete to generationNode and then use that in generation Strategy for moving forward (4) [Mby] skip max trial criterion addition if numtrials == -1 (5) add transition criterion to the repr string + some of the other fields that havent made it yet (6) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed Reviewed By: lena-kashtelyan Differential Revision: D50295684
|
This pull request has been merged in c1241e6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It is important that the transition criteria can tell the GenerationStrategy which node to move to once the criteria is met. This diff adds the transition_to field to TransitionCriterion
Things in the pipeline:
(1) Update the transition criterion class to check on a per node basis, instead of per experiment
(2) Use the transition criterion to determine if a node is complete
(3) add is_complete to generationNode and then use that in generation Strategy for moving forward
(4) [Mby] skip max trial criterion addition if numtrials == -1
(5) add transition criterion to the repr string + some of the other fields that havent made it yet
(6) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed
Reviewed By: lena-kashtelyan
Differential Revision: D50295684