Update use cases of deprecated fixed noise models #1920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitcakmak
force-pushed
the
export-D50431137
branch
from
b1c3553 to
7453760
Compare
Summary: Pull Request resolved: facebook#1915 The `use_update` setting of `GenerationStrategy` was deprecated in facebook#1895. This diff follows up to deprecate `update` from `ModelBridge` & `Model` APIs. All remaining mentions of update raise a `DeprecationWarning` and point the user to `fit` instead: `GenerationNode.use_update`, `ModelBridge.update` & `TorchModel.update`. Differential Revision: https://internalfb.com/D50351014 fbshipit-source-id: 60cf93cbdd3a5a56ce7fcf682d417b5dcca60e06
Summary: Pull Request resolved: facebook#1920 Updates use cases of fixed noise models that were deprecated in pytorch/botorch#2052 & elsewhere. The only remaining usage is `botorch_modular_registry`. I updated these to point to the parent models, so that they'll be less likely to cause backwards compatibility issues when we delete the models for good. Reviewed By: esantorella Differential Revision: D50431137 fbshipit-source-id: 604090019cfff8bc27ae01341a43d80142ef89c8
saitcakmak
force-pushed
the
export-D50431137
branch
from
7453760 to
3f30af6
Compare
facebook-github-bot
added
the
CLA Signed
|
pr is disconnected from diff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates use cases of fixed noise models that were deprecated in pytorch/botorch#2052 & elsewhere.
The only remaining usage is
botorch_modular_registry. I updated these to point to the parent models, so that they'll be less likely to cause backwards compatibility issues when we delete the models for good.Differential Revision: D50431137