Add generation_node_name arg to GeneratorRun #1918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50276770 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1918 +/- ##
=======================================
Coverage 94.58% 94.59%
=======================================
Files 459 459
Lines 43429 43438 +9
=======================================
+ Hits 41078 41089 +11
+ Misses 2351 2349 -2
☔ View full report in Codecov by Sentry. |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Oct 19, 2023
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile. For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so. While I was here, I also updated the functions with docstrings to abide by our standards :) Things in the pipeline: (1) Update other code impacted by this generator run change (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet Differential Revision: D50276770
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Oct 19, 2023
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile. For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so. While I was here, I also updated the functions with docstrings to abide by our standards :) Things in the pipeline: (1) Update other code impacted by this generator run change (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet Differential Revision: D50276770
mgarrard
force-pushed
the
export-D50276770
branch
from
64827e6 to
b02d4c7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50276770 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Oct 20, 2023
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile. For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so. While I was here, I also updated the functions with docstrings to abide by our standards :) Things in the pipeline: (1) Update other code impacted by this generator run change (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet Reviewed By: ItsMrLin Differential Revision: D50276770
mgarrard
force-pushed
the
export-D50276770
branch
from
b02d4c7 to
2732749
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50276770 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Oct 20, 2023
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile. For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so. While I was here, I also updated the functions with docstrings to abide by our standards :) Things in the pipeline: (1) Update other code impacted by this generator run change (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet Reviewed By: ItsMrLin Differential Revision: D50276770
mgarrard
force-pushed
the
export-D50276770
branch
from
2732749 to
5542802
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50276770 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Oct 23, 2023
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile. For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so. While I was here, I also updated the functions with docstrings to abide by our standards :) Things in the pipeline: (1) Update other code impacted by this generator run change (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet Reviewed By: ItsMrLin Differential Revision: D50276770
mgarrard
force-pushed
the
export-D50276770
branch
from
5542802 to
724aad9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50276770 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Oct 23, 2023
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile. For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so. While I was here, I also updated the functions with docstrings to abide by our standards :) Things in the pipeline: (1) Update other code impacted by this generator run change (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet Reviewed By: ItsMrLin Differential Revision: D50276770
mgarrard
force-pushed
the
export-D50276770
branch
from
724aad9 to
3f12f06
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50276770 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50276770 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 23, 2023
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile. For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so. While I was here, I also updated the functions with docstrings to abide by our standards :) Things in the pipeline: (1) Update other code impacted by this generator run change (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet Reviewed By: ItsMrLin Differential Revision: D50276770
mgarrard
force-pushed
the
export-D50276770
branch
from
3f12f06 to
ae888e4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50276770 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Oct 23, 2023
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile. For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so. While I was here, I also updated the functions with docstrings to abide by our standards :) Things in the pipeline: (1) Update other code impacted by this generator run change (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet Reviewed By: ItsMrLin Differential Revision: D50276770
mgarrard
force-pushed
the
export-D50276770
branch
from
ae888e4 to
d230844
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50276770 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Oct 23, 2023
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile. For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so. While I was here, I also updated the functions with docstrings to abide by our standards :) Things in the pipeline: (1) Update other code impacted by this generator run change (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet Reviewed By: ItsMrLin Differential Revision: D50276770
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile. For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so. While I was here, I also updated the functions with docstrings to abide by our standards :) Things in the pipeline: (1) Update other code impacted by this generator run change (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet Reviewed By: ItsMrLin Differential Revision: D50276770
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 24, 2023
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile. For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so. While I was here, I also updated the functions with docstrings to abide by our standards :) Things in the pipeline: (1) Update other code impacted by this generator run change (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet Reviewed By: ItsMrLin Differential Revision: D50276770
mgarrard
force-pushed
the
export-D50276770
branch
from
d230844 to
b9c714f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50276770 |
|
This pull request has been merged in bfccae0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to GeneratorRun. This arg is analogous to the generation_step_index, but more flexibile.
For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so.
While I was here, I also updated the functions with docstrings to abide by our standards :)
Things in the pipeline:
(1) Update other code impacted by this generator run change
(2) Add the transition_to field to transition criterion class
(3) Update the transition criterion class to check on a per node basis, instead of per experiment
(4) add is_complete to generationNode and then use that in generation Strategy for moving forward
(5) [Mby] skip max trial criterion addition if numtrials == -1
(6) add transition criterion to the repr string + some of the other fields that havent made it yet
Differential Revision: D50276770