Migrate Alebo from code deprecated in closures refactor #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50206581 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
==========================================
- Coverage 94.61% 94.60% -0.01%
==========================================
Files 459 459
Lines 43685 43771 +86
==========================================
+ Hits 41333 41410 +77
- Misses 2352 2361 +9
☔ View full report in Codecov by Sentry. |
Summary: ALEBO generally provides inferior performance to SAASBO and is a maintenance burden. Differential Revision: https://internalfb.com/D50203060 fbshipit-source-id: acca3e0bf45abce680b0b64fa7a836015c41bdfe
Summary: Pull Request resolved: facebook#1906 ALEBO is using deprecated functionality from BoTorch that is soon to be removed entirely. Because ALEBO itself is deprecated, it is not worth porting this to modern BoTorch. So ALEBO will simply keep a copy of the BoTorch code (with some branches that are not needed removed). Reviewed By: saitcakmak Differential Revision: D50206581 fbshipit-source-id: 7f506f22a8704b563a97ca092fab2374cedf1d5e
|
This pull request was exported from Phabricator. Differential Revision: D50206581 |
esantorella
force-pushed
the
export-D50206581
branch
from
9f281ac to
568f572
Compare
|
This pull request has been merged in 7749c7a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: ALEBO is using deprecated functionality from BoTorch that is soon to be removed entirely. Because ALEBO itself is deprecated, it is not worth porting this to modern BoTorch. So ALEBO will simply keep a copy of the BoTorch code (with some branches that are not needed removed).
Differential Revision: D50206581