Add target task values to SearchSpaceDigest #1894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Task parameters have a "target_value" attribute, but we haven't been using it; it has previously only been used for fidelity parameters. But at the core level, there's nothing in its implementation that would restrict its use to fidelity parameters. But all of our applications of multi-task models have a target task, and the new MultiTaskDataset in botorch requires specifying a target task. In order to migrate our multi-task models to use MultiTaskDataset (D49604249), we need to have a target task. This diff makes target_value a required attribute for task parameters, the same way it is currently required for fidelity parameters. Propagating the target value to the search space digest will happen in a stacked diff. Transforms that create task parameters (TrialAsTask and MetricsAsTask) are adjusted to appropriately specify the target value. Differential Revision: D49659731 fbshipit-source-id: 47d66c06f86f58722703698d02d4626a38f46967
Summary: Earlier in this stack we add "target_value" as a required attribute for task parameters, like it has been for fidelity parameters. The first place in the stack where "target_value" is considered to be exclusively for fidelity parameters is in SearchSpaceDigest, so this adjusts the logic there to also track target values for task parameters. And renames the attribute, to make it more clear that it is not restricted to fidelity parameters. Differential Revision: D49701286 fbshipit-source-id: ca3b7af107f371d9f501a3fe0b90fec00a85d726
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49701286 |
|
This pull request has been merged in dd10bee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Earlier in this stack we add "target_value" as a required attribute for task parameters, like it has been for fidelity parameters. The first place in the stack where "target_value" is considered to be exclusively for fidelity parameters is in SearchSpaceDigest, so this adjusts the logic there to also track target values for task parameters. And renames the attribute, to make it more clear that it is not restricted to fidelity parameters.
Differential Revision: D49701286