Add storage backwards compatibility test for SurrogateSpec #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Investigating the failures reported in https://www.internalfb.com/diff/D49609383?dst_version_fbid=1010508330295901&transaction_fbid=1339834640257223 This does not reproduce the error but we might as well add the test. Reviewed By: susanxia1006 Differential Revision: D49832749
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49832749 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
==========================================
- Coverage 94.56% 94.56% -0.01%
==========================================
Files 460 460
Lines 43531 43533 +2
==========================================
+ Hits 41164 41165 +1
- Misses 2367 2368 +1
☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 7569ca7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Investigating the failures reported in https://www.internalfb.com/diff/D49609383?dst_version_fbid=1010508330295901&transaction_fbid=1339834640257223
This does not reproduce the error but we might as well add the test.
Reviewed By: susanxia1006
Differential Revision: D49832749