MBM Surrogate: Clean up model fitting behavior and **kwargs usage #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49707895 |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1882 +/- ##
==========================================
+ Coverage 94.60% 94.62% +0.01%
==========================================
Files 459 459
Lines 43771 43730 -41
==========================================
- Hits 41410 41378 -32
+ Misses 2361 2352 -9
☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Sep 28, 2023
…cebook#1882) Summary: Kwargs: These were originally added to support passing around additional kwargs in subclasses that no-longer exist. They later silently took on the role of carrying the kwargs that gets passed down to model input constructors. The argument name has been updated with added docstring explaining what these do. These are now used to update `Surrogate.model_options` and passed to the input constructors from there. Model fitting clean up: We had a bunch of duplicate logic for constructing the models, left over from the merger of `Surrogate` & `ListSurrogate`, which led to several bugs in the past and made the code much harder to maintain and review. This diff deduplicates and simplifies the model fitting logic. Differential Revision: D49707895
saitcakmak
force-pushed
the
export-D49707895
branch
from
a6b1361 to
c67d597
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49707895 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Sep 29, 2023
…cebook#1882) Summary: Kwargs: These were originally added to support passing around additional kwargs in subclasses that no-longer exist. They later silently took on the role of carrying the kwargs that gets passed down to model input constructors. The argument name has been updated with added docstring explaining what these do. These are now used to update `Surrogate.model_options` and passed to the input constructors from there. Model fitting clean up: We had a bunch of duplicate logic for constructing the models, left over from the merger of `Surrogate` & `ListSurrogate`, which led to several bugs in the past and made the code much harder to maintain and review. This diff deduplicates and simplifies the model fitting logic. Differential Revision: D49707895
saitcakmak
force-pushed
the
export-D49707895
branch
from
c67d597 to
74f28ce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49707895 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Sep 29, 2023
…cebook#1882) Summary: Kwargs: These were originally added to support passing around additional kwargs in subclasses that no-longer exist. They later silently took on the role of carrying the kwargs that gets passed down to model input constructors. The argument name has been updated with added docstring explaining what these do. These are now used to update `Surrogate.model_options` and passed to the input constructors from there. Model fitting clean up: We had a bunch of duplicate logic for constructing the models, left over from the merger of `Surrogate` & `ListSurrogate`, which led to several bugs in the past and made the code much harder to maintain and review. This diff deduplicates and simplifies the model fitting logic. Differential Revision: D49707895
saitcakmak
force-pushed
the
export-D49707895
branch
from
74f28ce to
b277048
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49707895 |
saitcakmak
force-pushed
the
export-D49707895
branch
from
b277048 to
7039fc7
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 6, 2023
…cebook#1882) Summary: Kwargs: These were originally added to support passing around additional kwargs in subclasses that no-longer exist. They later silently took on the role of carrying the kwargs that gets passed down to model input constructors. The argument name has been updated with added docstring explaining what these do. These are now used to update `Surrogate.model_options` and passed to the input constructors from there. Model fitting clean up: We had a bunch of duplicate logic for constructing the models, left over from the merger of `Surrogate` & `ListSurrogate`, which led to several bugs in the past and made the code much harder to maintain and review. This diff deduplicates and simplifies the model fitting logic. Differential Revision: D49707895
|
This pull request was exported from Phabricator. Differential Revision: D49707895 |
saitcakmak
force-pushed
the
export-D49707895
branch
from
7039fc7 to
a1eed58
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 6, 2023
…cebook#1882) Summary: Kwargs: These were originally added to support passing around additional kwargs in subclasses that no-longer exist. They later silently took on the role of carrying the kwargs that gets passed down to model input constructors. The argument name has been updated with added docstring explaining what these do. These are now used to update `Surrogate.model_options` and passed to the input constructors from there. Model fitting clean up: We had a bunch of duplicate logic for constructing the models, left over from the merger of `Surrogate` & `ListSurrogate`, which led to several bugs in the past and made the code much harder to maintain and review. This diff deduplicates and simplifies the model fitting logic. Differential Revision: D49707895
|
This pull request was exported from Phabricator. Differential Revision: D49707895 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 6, 2023
…cebook#1882) Summary: Pull Request resolved: facebook#1882 Kwargs: These were originally added to support passing around additional kwargs in subclasses that no-longer exist. They later silently took on the role of carrying the kwargs that gets passed down to model input constructors. The argument name has been updated with added docstring explaining what these do. These are now used to update `Surrogate.model_options` and passed to the input constructors from there. Model fitting clean up: We had a bunch of duplicate logic for constructing the models, left over from the merger of `Surrogate` & `ListSurrogate`, which led to several bugs in the past and made the code much harder to maintain and review. This diff deduplicates and simplifies the model fitting logic. Differential Revision: https://internalfb.com/D49707895 fbshipit-source-id: c99838e7619dc120ccd280cde3ef8cd4e376cfe1
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 6, 2023
…cebook#1882) Summary: Pull Request resolved: facebook#1882 Kwargs: These were originally added to support passing around additional kwargs in subclasses that no-longer exist. They later silently took on the role of carrying the kwargs that gets passed down to model input constructors. The argument name has been updated with added docstring explaining what these do. These are now used to update `Surrogate.model_options` and passed to the input constructors from there. Model fitting clean up: We had a bunch of duplicate logic for constructing the models, left over from the merger of `Surrogate` & `ListSurrogate`, which led to several bugs in the past and made the code much harder to maintain and review. This diff deduplicates and simplifies the model fitting logic. Differential Revision: https://internalfb.com/D49707895 fbshipit-source-id: 7dc375023b37a17468682e0bf602949a25063ff3
…cebook#1882) Summary: Kwargs: These were originally added to support passing around additional kwargs in subclasses that no-longer exist. They later silently took on the role of carrying the kwargs that gets passed down to model input constructors. The argument name has been updated with added docstring explaining what these do. These are now used to update `Surrogate.model_options` and passed to the input constructors from there. Model fitting clean up: We had a bunch of duplicate logic for constructing the models, left over from the merger of `Surrogate` & `ListSurrogate`, which led to several bugs in the past and made the code much harder to maintain and review. This diff deduplicates and simplifies the model fitting logic. Reviewed By: esantorella Differential Revision: D49707895
saitcakmak
force-pushed
the
export-D49707895
branch
from
a1eed58 to
31f5f34
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49707895 |
|
This pull request has been merged in 63fdfd8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Kwargs: These were originally added to support passing around additional kwargs in subclasses that no-longer exist. They later silently took on the role of carrying the kwargs that gets passed down to model input constructors. The argument name has been updated with added docstring explaining what these do. These are now used to update
Surrogate.model_optionsand passed to the input constructors from there.Model fitting clean up: We had a bunch of duplicate logic for constructing the models, left over from the merger of
Surrogate&ListSurrogate, which led to several bugs in the past and made the code much harder to maintain and review. This diff deduplicates and simplifies the model fitting logic.Differential Revision: D49707895