make constraints optional in get_experiment... functions #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46687301 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Jun 13, 2023
Summary: Pull Request resolved: facebook#1657 For get_experiment... core stubs functions that create a trial with Sobol, constraints were resulting in the logs being flooded with "Unable to round" warnings due to rejection sampling. This diff omits these constraints in test_sqa_store tests for which they are immaterial. Differential Revision: D46687301 fbshipit-source-id: d9e4ec112c5624e12e96669744e2210de09bc29a
bernardbeckerman
force-pushed
the
export-D46687301
branch
from
f9a7e9f to
5a9e76c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46687301 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 22, 2023
Summary: For get_experiment... core stubs functions that create a trial with Sobol, constraints were resulting in the logs being flooded with "Unable to round" warnings due to rejection sampling. This diff omits these constraints in test_sqa_store tests for which they are immaterial. Reviewed By: Balandat Differential Revision: D46687301
bernardbeckerman
force-pushed
the
export-D46687301
branch
from
5a9e76c to
9b14f2d
Compare
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 22, 2023
Summary: For get_experiment... core stubs functions that create a trial with Sobol, constraints were resulting in the logs being flooded with "Unable to round" warnings due to rejection sampling. This diff omits these constraints in test_sqa_store tests for which they are immaterial. Reviewed By: Balandat Differential Revision: D46687301
|
This pull request was exported from Phabricator. Differential Revision: D46687301 |
Summary: For get_experiment... core stubs functions that create a trial with Sobol, constraints were resulting in the logs being flooded with "Unable to round" warnings due to rejection sampling. This diff omits these constraints in test_sqa_store tests for which they are immaterial. Reviewed By: Balandat Differential Revision: D46687301
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 27, 2023
Summary: For get_experiment... core stubs functions that create a trial with Sobol, constraints were resulting in the logs being flooded with "Unable to round" warnings due to rejection sampling. This diff omits these constraints in test_sqa_store tests for which they are immaterial. Reviewed By: Balandat Differential Revision: D46687301
bernardbeckerman
force-pushed
the
export-D46687301
branch
from
9b14f2d to
f107d33
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46687301 |
bernardbeckerman
force-pushed
the
export-D46687301
branch
from
f107d33 to
595669a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46687301 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 27, 2023
Summary: For get_experiment... core stubs functions that create a trial with Sobol, constraints were resulting in the logs being flooded with "Unable to round" warnings due to rejection sampling. This diff omits these constraints in test_sqa_store tests for which they are immaterial. Reviewed By: Balandat Differential Revision: D46687301
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1657 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 460 460
Lines 44258 44262 +4
=======================================
+ Hits 41832 41836 +4
Misses 2426 2426 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 1e49f25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For get_experiment... core stubs functions that create a trial with Sobol, constraints were resulting in the logs being flooded with "Unable to round" warnings due to rejection sampling. This diff omits these constraints in test_sqa_store tests for which they are immaterial.
Differential Revision: D46687301