Skip to content

Commit

Permalink
Change default MapKeyInfo (#3194)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #3194
I want to converge around the "step" column name (as we use in the API) as opposed to "steps" -- this may not matter in the long run as we rethink mapdata, but I think now is the time to do it.

cc ltiao who has diffs in flight that may be effected by this.

Lets see if this breaks anything -- shouldnt actually be used anywhere except maybe tests.

Reviewed By: saitcakmak

Differential Revision: D67413011

fbshipit-source-id: f23cb6c86aed24b643e53d119cb681cbefc5c13e
  • Loading branch information
mpolson64 authored and facebook-github-bot committed Dec 19, 2024
1 parent 7611c5b commit 7bb3fe4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ax/core/map_metric.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ class MapMetric(Metric):
"""

data_constructor: type[MapData] = MapData
map_key_info: MapKeyInfo[float] = MapKeyInfo(key="steps", default_value=0.0)
map_key_info: MapKeyInfo[float] = MapKeyInfo(key="step", default_value=0.0)
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def test_Init(self) -> None:
"parameters": {MapKeyToFloat.DEFAULT_MAP_KEY: {"log_scale": False}}
},
)
self.assertDictEqual(t.parameters, {"steps": {"log_scale": False}})
self.assertDictEqual(t.parameters, {"step": {"log_scale": False}})

self.assertEqual(len(t._parameter_list), 1)

Expand Down

0 comments on commit 7bb3fe4

Please sign in to comment.