Skip to content

Commit

Permalink
Expose properties column in SQATrial
Browse files Browse the repository at this point in the history
Summary: In MLHub, we use the properties column to store additional metadata on trials. We via access this via our custom MLHubDecoder, but we need to expose this column via SQA first.

Reviewed By: lena-kashtelyan

Differential Revision: D21064787

fbshipit-source-id: ba12059fdd08f7e93d6b19ee813831954b8f5f75
  • Loading branch information
Steve Mandala authored and facebook-github-bot committed Apr 17, 2020
1 parent 53fc18b commit 781a1d0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions ax/storage/sqa_store/sqa_classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ class SQATrial(Base):
time_run_started: Optional[datetime] = Column(IntTimestamp)
trial_type: Optional[str] = Column(String(NAME_OR_TYPE_FIELD_LENGTH))
generation_step_index: Optional[int] = Column(Integer)
properties: Optional[Dict[str, Any]] = Column(JSONEncodedTextDict, default={})

# relationships
# Trials and experiments are mutable, so the children relationships need
Expand Down
3 changes: 2 additions & 1 deletion ax/storage/sqa_store/tests/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@
"num_arms_created": "num_arms_created",
},
python_only=["experiment", "status_quo", "status_quo_weight_override"],
encoded_only=["is_batch", "status_quo_name", "deployed_name"],
encoded_only=["is_batch", "status_quo_name", "deployed_name", "properties"],
),
"BraninObjective": EncodeDecodeFieldsMap(
python_only=["metric"],
Expand Down Expand Up @@ -434,6 +434,7 @@
"status_quo_name",
"deployed_name",
"optimize_for_power",
"properties",
],
),
}

0 comments on commit 781a1d0

Please sign in to comment.