Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototyped a more advanced query type parameters UI #7

Closed
wants to merge 3 commits into from
Closed

Prototyped a more advanced query type parameters UI #7

wants to merge 3 commits into from

Conversation

bdunogier
Copy link
Member

@bdunogier bdunogier commented Dec 13, 2019 •
edited
Loading

Once a query type has been selected, a text line form widget is shown for for each parameter defined for the Query Type.

Parameters editing form

TODO

  • Make the newly added text translatable
  • Make query type parameters translatable (extractor ?)

Ideas

  • When no translations are available, fallback to making the parameters name more humanly readable (parent_location_id-> "Parent location id")
  • Improve the query type API: required parameters, default value (shown as placeholder in the form), ... ?

@bdunogier bdunogier force-pushed the better_parameters_form branch from 41ff8f3 to f2e208d Compare December 13, 2019 16:59
@bdunogier bdunogier closed this Dec 13, 2019
@bdunogier bdunogier deleted the better_parameters_form branch December 13, 2019 17:03
@bdunogier bdunogier reopened this Dec 13, 2019
@bdunogier bdunogier mentioned this pull request Dec 22, 2019
Draft
6 tasks
@bdunogier
Copy link
Member Author

Prototype closed in favour of #13.

@bdunogier bdunogier closed this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdunogier