Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8562: Fixed flooding content attributes table with duplicates #409

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

Nattfarinn
Copy link
Contributor

+ IBX-8492: Fixed replacing only field of Content Type with virtual field

Question Answer
JIRA issue IBX-8562, IBX-8492
Type bug
Target Ibexa version v3.3
BC breaks no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@Steveb-p
Copy link
Contributor

Given how the issue comes up when multiple layers interact with each other, this almost requires tests - either adjustment of already present ones, or new ones.

I'd accept this only with an explanation why this works, ideally with a promise of tests being added at least to 4.6 to show the issue in the new testing framework.

@mnocon
Copy link
Member

mnocon commented Jul 25, 2024

The JIRA ticket mentions a SQL script to remove the duplicated entries - if we decide to create one please let us (the Knowledge Team) know, we will have to document it in the update doc

Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status of retests.

https://issues.ibexa.co/browse/IBX-8562
OK

https://issues.ibexa.co/browse/IBX-8492
Content view works but editing item causes error:
(under verification by @Nattfarinn)

Screenshot 2024-07-26 at 14 26 07

@eWert-Online
Copy link

Hello 👋

since the creation of this PR, our clients database grew an additional 5 million rows and 2 GB in disk size.
Please provide a fix for this issue as fast as possible.

Thank you!

db

@Nattfarinn Nattfarinn requested a review from micszo July 31, 2024 07:11
@Nattfarinn Nattfarinn force-pushed the fix-virtual-fields branch from 3d1f30c to 36b051b Compare July 31, 2024 07:13
@micszo
Copy link
Member

micszo commented Jul 31, 2024

Retest status: on v3.3 404 persists when editing item with only field replaced.

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still missing some coverage on integration level, with database.
You should be able to query database via tests by getting \Doctrine\DBAL\Connection service from the test container (it's already exposed).

// for 4.6

@alongosz alongosz requested a review from a team August 5, 2024 08:29
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK from my side now.

@eWert-Online
Copy link

Hi 🙂

we now have ~10 million duplicates in our table and the database grew around 3GB in disk size.

Since a few days, the production database is throwing error messages (SQLSTATE[HY000]: General error: 1114 The table 'ezcontentobject_attribute' is full).
Some SQL queries fail with Fatal Error: Allowed memory size exhausted.

...but sure... take your time discussing what kind of null check you want to do. Nothing to worry about!

fine

@adamwojs
Copy link
Member

adamwojs commented Aug 6, 2024

Hi @eWert-Online!

First of all my apologies for the situation. I understand your frustration but I would like to ensure you that we are aware of importance of this patch and we are actively working on providing the solution.

Unfortunately, Github does not give a full visibility of our intense activities behind the scenes. Currently proposed changes are going through Quality Assurance process. As soon as we will be ready we will do the 3.3.40 and 4.6.10 release.

@Nattfarinn Nattfarinn requested review from alongosz and Steveb-p August 7, 2024 07:45
Copy link

sonarcloud bot commented Aug 7, 2024

@alongosz alongosz merged commit 9a62410 into 1.3 Aug 7, 2024
23 checks passed
@alongosz alongosz deleted the fix-virtual-fields branch August 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.