Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8019: Refactored Object State Id criterion #405

Closed
wants to merge 1 commit into from

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Mar 25, 2024

Question Answer
JIRA issue IBX-8019
Type bug
Target Ibexa version v3.3
BC breaks yes/no

The reason for the performance drop caused by #401 is the fact that we can have literally hundreds of join of the same table if there are so many object state.

I would say the real cause of the problem is the criterion building itself.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@barw4 barw4 added Bug Something isn't working Ready for review labels Mar 25, 2024
@barw4 barw4 self-assigned this Mar 25, 2024
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@barw4 barw4 closed this Mar 26, 2024
@barw4 barw4 deleted the ibx-8019-refactor-object-state-criterion branch March 26, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for review
Development

Successfully merging this pull request may close these issues.

3 participants