IBX-7579:Richtext: Rows are added to ezurl_object_link on every save #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
vidarl
commented
Feb 13, 2024
eZ/Publish/Core/FieldType/Url/UrlStorage/Gateway/DoctrineStorage.php
Outdated
Show resolved
Hide resolved
|
The duplicate entries doesn't cause any harm besides performance and storage. |
vidarl
force-pushed
the
ibx-7579_rows_are_added_to_ezurl_object_link_on_every_save_by_richtext
branch
from
69af424 to
c5e827d
Compare
|
@webhdx : Rebased on top of latest 1.3 branch ( was just 2 commits behind though ) |
vidarl
force-pushed
the
ibx-7579_rows_are_added_to_ezurl_object_link_on_every_save_by_richtext
branch
from
c5e827d to
54e2918
Compare
|
|
@webhdx : tmp commits removed |
alongosz
reviewed
May 8, 2024
eZ/Publish/Core/FieldType/Tests/Url/Gateway/DoctrineStorageTest.php
Outdated
Show resolved
Hide resolved
…y save: Changed unit test into integration test
vidarl
force-pushed
the
ibx-7579_rows_are_added_to_ezurl_object_link_on_every_save_by_richtext
branch
from
c16dafe to
1c1c742
Compare
alongosz
reviewed
Jun 13, 2024
eZ/Publish/Core/FieldType/Tests/Integration/Url/UrlStorage/UrlStorageGatewayTest.php
Outdated
Show resolved
Hide resolved
tests/integration/Core/FieldType/Url/UrlStorage/Gateway/UrlDoctrineStorageGatewayTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/FieldType/Tests/Integration/Url/UrlStorage/UrlStorageGatewayTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/FieldType/Tests/Integration/Url/UrlStorage/UrlStorageGatewayTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/FieldType/Url/UrlStorage/Gateway/DoctrineStorage.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/FieldType/Url/UrlStorage/Gateway/DoctrineStorage.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/FieldType/Url/UrlStorage/Gateway/DoctrineStorage.php
Outdated
Show resolved
Hide resolved
…on every save: Changed unit test into integration test
…on every save: Changed unit test into integration test
…t_link on every save: Changed unit test into integration test
…l_object_link on every save: Changed unit test into integration test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Makes it possible to get data from
ezurl_object_linktable. This is needed by richtext bundle in orderto avoid duplicate links entries to be added to table.
Corresponding richtext PR : ezsystems/ezplatform-richtext#242
For QA:
Documentation: