add implementation #1
Conversation
|
Need to add angular module that can be added to the main project. |
example/js/controller.js
Outdated
| window.scope = $scope; | ||
| window.rootScope = $rootScope; | ||
|
|
||
| console.log(data); |
There was a problem hiding this comment.
@trean remove please console log
example/js/scalableTable.js
Outdated
| @@ -0,0 +1,840 @@ | |||
| angular.module('scalable-table', []) | |||
There was a problem hiding this comment.
@trean why don't you use main scalableTable.js directive instead of duplicating it here?
There was a problem hiding this comment.
@myfoxtail I thought that it will be easier to an user to run the example. It don't requires from an user path to URl which looks like http://some-url/example. But other side it can confuse user. So maybe it needs to changes. Is it OK if I'll remove this file from example directory and use main directive?
There was a problem hiding this comment.
@trean The problem is that if you change something in the main script you have to change it in the example. It's not convenient. I think yes, you can use the file from the main directive.
There was a problem hiding this comment.
@myfoxtail I have used main file now. But I should been change the line 83 to scope.$on('$destroy', function() { There is removed $, because it caused an error.
There was a problem hiding this comment.
@trean ok, thanks, we will handle it later
example/js/controller.js
Outdated
| return arr; | ||
| }); | ||
| console.log($scope.tableData); | ||
| console.log($scope.tableData.length); |
example/js/controller.js
Outdated
| }; | ||
|
|
||
| $scope.gotoFoo = function (key) { | ||
| console.log(key) |
example/js/scalableTable.js
Outdated
|
|
||
| return { | ||
| post: function(scope, elem, attrs) { | ||
| console.log(scope.scalableTableColumns); |
There was a problem hiding this comment.
@trean remove please console.log here too.
There was a problem hiding this comment.
It do not need anymore (I use main file now where is not exist this line).
scalableTable.js
Outdated
|
|
||
| return { | ||
| post: function(scope, elem, attrs) { | ||
| console.log(scope.scalableTableColumns); |
There was a problem hiding this comment.
@trean remove console log here too, please.
|
@trean could you also please add working example that includes 10000 rows and 300 columns for example. |
|
|
Need to add doc and examples