Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI snapshot test for simple case #2368

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cruessler
Copy link
Contributor

@cruessler cruessler commented Sep 23, 2024

This is a PR for a branch that I have been working on a couple of weeks ago. I did not want this to get lost, so I decided to open a PR, in particular because I discovered there were some open questions with respect to UI tests.

I think this works really well for cases where the program exits with an error message.

I found it quite challenging, though, when it comes to testing an application interactively because snapbox, the library that powers the snapshot test, isn’t designed for that use case. There’s potentially ways to work around that via environment variables or command line arguments, but before I go down that route, I first wanted to get your opinion on whether you think it’s worth putting more effort into this. I still think if we can get this to work, we’d have the option to write truly useful high-level regression tests of which I’m a big fan. What do you think? @extrawurst

2024-09-24: I’ll add more context and fix the failing test soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant