Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/param id http decorator failing #39

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Conversation

rsaz
Copy link
Member

@rsaz rsaz commented Jun 11, 2024

Pull Request Guidelines

Our guidelines for submitting a pull request.

Before submitting a Pull Request, please make sure you have verified the following:

  • The commit message follows our guidelines:
    • A good commit message should be two things: meaningful and concise. It should not contain every single detail, describing each changed line—we can see all the changes in Git—but, at the same time, it should say enough to avoid ambiguity.
    • We use Microverse's commit message convention
    • The convention stablish that a commit message has to be in the present tense, imperative and lowercase.
    • Example: fix typo in README.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.
@Http decorator no setting the status when used combined with the @param decorator

Issue Number: N/A

What is the new behavior?

Describe the new behavior or link to a relevant issue.

  • Different HTTP Methods can set status for the same route
  • In a MVC pattern where multiple routes are in the same controller @http decorator respects the top down order of the endpoints
  • @Http decorator can recognize what is a static route and what is a parameter

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.

Other information

Any other information that is important to this PR.

@rsaz rsaz added the bug Something isn't working label Jun 11, 2024
@rsaz rsaz merged commit 4cf0563 into main Jun 11, 2024
5 checks passed
@rsaz rsaz deleted the fix/param-id-http-decorator-failing branch June 11, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants