Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] wording tweaks for messages #2790

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Dec 24, 2024

Why

Fixes ENG-14562
Fixes ENG-14458
Fixes ENG-10850

How

Wording tweaks for EAS CLI messages.

Test Plan

The changes have been reviewed by running CLI locally.

Preview

Screenshot 2024-12-24 at 14 01 19

Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Dec 24, 2024

Size Change: +3.18 kB (+0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +3.18 kB (+0.01%)

compressed-size-action

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.51%. Comparing base (a1d086f) to head (e781a24).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/device/delete.ts 0.00% 2 Missing ⚠️
packages/eas-cli/src/commands/device/rename.ts 0.00% 2 Missing ⚠️
...eProjectIDForWriteToConfigWithConfirmationAsync.ts 0.00% 2 Missing ⚠️
packages/eas-cli/src/utils/statuspageService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2790   +/-   ##
=======================================
  Coverage   52.51%   52.51%           
=======================================
  Files         583      583           
  Lines       22582    22582           
  Branches     4452     4452           
=======================================
  Hits        11856    11856           
  Misses      10691    10691           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Simek Simek force-pushed the @simek/eas-cli-wording-tweaks branch from 0cbfcdf to e781a24 Compare December 24, 2024 13:52
Copy link

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant