Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Add interactivity to eas update:edit command #2638

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Oct 18, 2024

Why

When writing the docs for update-based rollouts, I noticed that a) this command was still hidden, and b) it didn't have the best UX for interactive mode (#2503 didn't add it)

How

a) unhide the command
b) Make group arg optional, add optional branch flag, and lead user through interactive process to choose an update group to edit if not supplied as an arg

Note that this doesn't filter update groups to those that are editable since it isn't currently possible to query. We can update this in the future if we want, but usability of the feature probably won't suffer much without it since it's likely the latest update group will always be the one chosen to be edited.

Test Plan

neas update:edit
neas update:edit --branch main

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite Graphite

@wschurman wschurman requested a review from quinlanj October 18, 2024 21:43
@wschurman wschurman marked this pull request as ready for review October 18, 2024 21:43
Copy link

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/commands/update/** @EvanBacon, @byCedric, @wschurman

Copy link

github-actions bot commented Oct 18, 2024

Size Change: -2.16 kB (0%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB -2.16 kB (0%)

compressed-size-action

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 53.09%. Comparing base (f0b14bf) to head (b110bb9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/update/edit.ts 14.29% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2638      +/-   ##
==========================================
- Coverage   53.11%   53.09%   -0.02%     
==========================================
  Files         566      566              
  Lines       21588    21601      +13     
  Branches     4225     4228       +3     
==========================================
+ Hits        11465    11466       +1     
- Misses      10093    10105      +12     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman wschurman force-pushed the @wschurman/10-18-_eas-cli_add_interactivity_to_eas_update_edit_command branch from 72aa3d8 to b110bb9 Compare October 21, 2024 21:18
Copy link

✅ Thank you for adding the changelog entry!

@wschurman wschurman merged commit 49dba20 into main Oct 21, 2024
7 checks passed
@wschurman wschurman deleted the @wschurman/10-18-_eas-cli_add_interactivity_to_eas_update_edit_command branch October 21, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants